Merge lp://staging/~stolowski/unity-scope-mediascanner/support-artists into lp://staging/unity-scope-mediascanner

Proposed by Paweł Stołowski
Status: Merged
Approved by: Pete Woods
Approved revision: 152
Merged at revision: 145
Proposed branch: lp://staging/~stolowski/unity-scope-mediascanner/support-artists
Merge into: lp://staging/unity-scope-mediascanner
Diff against target: 533 lines (+204/-57)
6 files modified
CMakeLists.txt (+2/-0)
debian/control (+3/-0)
src/music-scope.cpp (+152/-38)
src/music-scope.h (+10/-2)
src/musicaggregatorquery.cpp (+1/-1)
tests/test-music-scope.cpp (+36/-16)
To merge this branch: bzr merge lp://staging/~stolowski/unity-scope-mediascanner/support-artists
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Pete Woods (community) Approve
Review via email: mp+229929@code.staging.launchpad.net

Commit message

Implemented "Artists" department. Show photos of matching artists on search. Clicking an artist results goes into a 'fake' department, which shows large artist photo, biography and albums.
Introduce two new dependencies: net-cpp and jsoncpp.

Description of the change

Updated for final designs:
- implemented "Artists" department;
- show photos of matching artists on search;
- clicking an artist results goes into a 'fake' department, which shows large artist photo, biography and albums.

This MR introduces two new dependencies: net-cpp and jsoncpp.

Note: this branch needs the following to work properly:

* support for artist art in the thumbnailer
https://code.launchpad.net/~stolowski/thumbnailer/support-artist-art/+merge/229422

* don't requst previews for scope:// uris (just execute search):
https://code.launchpad.net/~aacid/unity8/scopeActivatePreview/+merge/228624

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Pete Woods (pete-woods) :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Pete Woods (pete-woods) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: