Unity Media Scanner Scope

Merge lp://staging/~stolowski/unity-scope-mediascanner/dont-pass-artist-by-search-string into lp://staging/unity-scope-mediascanner

  1. dont-pass-artist-by-search-string
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Work in progress
Proposed branch: lp://staging/~stolowski/unity-scope-mediascanner/dont-pass-artist-by-search-string
Merge into: lp://staging/unity-scope-mediascanner
Diff against target: 202 lines (+84/-21)
2 files modified
src/mymusic/music-scope.cpp (+67/-13)
tests/test-music-scope.cpp (+17/-8)
To merge this branch: bzr merge lp://staging/~stolowski/unity-scope-mediascanner/dont-pass-artist-by-search-string
Reviewer Review Type Date Requested Status
Paweł Stołowski (community) Needs Fixing
Marcus Tomlinson (community) Needs Fixing
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+288931@code.staging.launchpad.net

Commit message

Don't abuse search string to display albums-of-artist, pass it with user_data.

Description of the change

Don't abuse search string to display albums-of-artist. This unfortunately forced some changes to category renderers (because when search string is empty, surfacing mode was assumed), so this innocent change is bigger than expected.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:320
http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-ci/204/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-amd64-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-armhf-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-vivid-i386-ci/38
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-amd64-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-armhf-ci/31
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-mediascanner-wily-i386-ci/31

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-mediascanner-ci/204/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

As discussed on IRC: When I select an artist in my music, I don't have a back button top-left anymore.

review: Needs Fixing
Reply
Revision history for this message
Paweł Stołowski (stolowski) wrote :

This needs some more thought after all... It's not really about back button (which always leaves the scope and is only displayed when scope is not favorited) though.
After changing it to *not* abuse search string to pass artist name, it has an undesired side affect of not allowing user to go back to the scope's landing screen easily - in the existing code this can easily be done by tapping "X" in the search bar (which clears the artist name from search bar and goes back to the landing page of the scope). With this MP user has to select top-level department from the departments menu, which is not intuitive at all.

review: Needs Fixing
Reply

Unmerged revisions

320. By Paweł Stołowski

Fix category renderer again when searching in top department

319. By Paweł Stołowski

Fix category renderer when searching in top department

318. By Paweł Stołowski

Categories without quick-preview-type for songs-by-artist

317. By Paweł Stołowski

Fixes to inline playback

316. By Paweł Stołowski

Fix tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: