Merge lp://staging/~stolowski/unity-scope-click/local-departments into lp://staging/unity-scope-click/devel
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~stolowski/unity-scope-click/local-departments |
| Merge into: | lp://staging/unity-scope-click/devel |
| Diff against target: |
1506 lines (+902/-36) 24 files modified
debian/control (+1/-0) libclickscope/click/CMakeLists.txt (+4/-0) libclickscope/click/departments-db.cpp (+318/-0) libclickscope/click/departments-db.h (+100/-0) libclickscope/click/interface.cpp (+8/-2) libclickscope/click/interface.h (+3/-1) libclickscope/click/package.cpp (+9/-0) libclickscope/click/package.h (+2/-0) libclickscope/click/preview.cpp (+46/-7) libclickscope/click/preview.h (+9/-3) libclickscope/tests/CMakeLists.txt (+5/-1) libclickscope/tests/test_departments-db.cpp (+228/-0) libclickscope/tests/test_index.cpp (+4/-2) scope/clickapps/CMakeLists.txt (+2/-1) scope/clickapps/apps-query.cpp (+82/-7) scope/clickapps/apps-query.h (+3/-1) scope/clickapps/apps-scope.cpp (+11/-2) scope/clickapps/apps-scope.h (+4/-0) scope/clickstore/CMakeLists.txt (+2/-1) scope/clickstore/store-query.cpp (+39/-1) scope/clickstore/store-query.h (+3/-1) scope/clickstore/store-scope.cpp (+12/-2) scope/clickstore/store-scope.h (+2/-0) scope/tests/test_query.cpp (+5/-4) |
| To merge this branch: | bzr merge lp://staging/~stolowski/unity-scope-click/local-departments |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alejandro J. Cura (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Support for departments in click apps scope, for locally installed apps.
Description of the change
Support for departments in click apps scope, for locally installed apps.
Note: this is still WIP, and needs a change to /api/v1/package server call (as described on https:/
Unmerged revisions
- 317. By Paweł Stołowski
-
Uncomment unlink.
- 316. By Paweł Stołowski
-
Depend on sqlite >= 3.8.5 to ensure recursive sql statement is supported at runtime.
- 315. By Paweł Stołowski
-
Use recursive sql query when fetching packages from a department.
- 314. By Paweł Stołowski
-
Apply department filter when querying for locally installed apps.
- 313. By Paweł Stołowski
-
Throw on empty arguments to database store methods. Keep database in clickscope subdir.
- 312. By Paweł Stołowski
-
Store package - department mapping when displaying the preview.
- 311. By Paweł Stołowski
-
More checks in the test.
- 310. By Paweł Stołowski
-
Test department name updates.
- 309. By Paweł Stołowski
-
Fixes around table definitions; test for no duplicated records.
- 308. By Paweł Stołowski
-
Populdate department in details.
Great work pawel!
I know the branch is in progress, so let me give an initial observation: in order for the branch to be more easily reviewable, and to make sure that it does not grow much more, please split it in a few branches.
The first one should only include all the methods that do the queries and the db access, and all the corresponding tests.
The second one should start filling the db from preview.cpp using the branch above.
The third one would query the db to build the combo of departments.