unity-lens-shopping

Merge lp://staging/~stolowski/unity-lens-shopping/use-libunity-extras into lp://staging/unity-lens-shopping

  1. use-libunity-extras
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Michal Hruby
Approved revision: 33
Merged at revision: 32
Proposed branch: lp://staging/~stolowski/unity-lens-shopping/use-libunity-extras
Merge into: lp://staging/unity-lens-shopping
Diff against target: 330 lines (+11/-225)
5 files modified
configure.ac (+4/-2)
src/Makefile.am (+1/-2)
src/preview-player-client.vala (+0/-112)
src/scope.vala (+4/-4)
src/u1ms-preview.vala (+2/-105)
To merge this branch: bzr merge lp://staging/~stolowski/unity-lens-shopping/use-libunity-extras
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Michal Hruby (community) Approve
Review via email: mp+129164@code.staging.launchpad.net

Commit message

Removed PreviewPlayer client code. Use PreviewPlayerHandler from Unity.Extras (requires new libunity).

Description of the change

Removed PreviewPlayer client code. Use PreviewPlayerHandler from Unity.Extras (requires new libunity).

DON'T approve until https://code.launchpad.net/~stolowski/libunity/libunity-extras/+merge/129120 is merged!

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

+1

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/unity-lens-shopping-mbs-autolanding/1/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-shopping-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=amd64/1/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-lens-shopping-mbs-autolanding/./build=pbuilder,distribution=quantal,flavor=i386/1/console

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches