Merge lp://staging/~stolowski/unity-lens-shopping/u1ms-preview into lp://staging/unity-lens-shopping
Proposed by
Paweł Stołowski
| Status: | Merged |
|---|---|
| Approved by: | Paweł Stołowski |
| Approved revision: | 27 |
| Merged at revision: | 21 |
| Proposed branch: | lp://staging/~stolowski/unity-lens-shopping/u1ms-preview |
| Merge into: | lp://staging/unity-lens-shopping |
| Diff against target: |
431 lines (+350/-24) 6 files modified
po/POTFILES.in (+2/-0) po/POTFILES.skip (+2/-0) src/Makefile.am (+2/-0) src/preview-player-client.vala (+112/-0) src/scope.vala (+38/-24) src/u1ms-preview.vala (+194/-0) |
| To merge this branch: | bzr merge lp://staging/~stolowski/unity-lens-shopping/u1ms-preview |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Michal Hruby (community) | Approve | ||
|
Review via email:
|
|||
This proposal supersedes a proposal from 2012-09-25.
Commit message
Reuse u1ms preview code from musicstore scope for u1ms results. The code has been refactored and copied over to have it isolated as much as possible in new classes/files. After Q we need to move it to a library and clean both shopping lens and musicstore scope.
Description of the change
Reuse u1ms preview code from musicstore scope for u1ms results. The code has been refactored and copied over to have it isolated as much as possible in new classes/files. After Q we need to move it to a library and clean both shopping lens and musicstore scope.
To post a comment you must log in.
Revision history for this message
| Michal Hruby (mhr3) wrote | # |
Revision history for this message
| Paweł Stołowski (stolowski) wrote | # |
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Revision history for this message
| Michal Hruby (mhr3) | # |
review:
Approve
Revision history for this message
| Unity Merger (unity-merger) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Can you please add huge WARNING / FIXME comment on the top saying that the file is a copy, and should be kept in sync with the original / moved in a common lib.
Otherwise looks and works fine.