Merge lp://staging/~stolowski/unity-lens-music/unity-lens-music.previews into lp://staging/unity-lens-music

Nice work, works pretty well, but it's over 1k lines, so you know the drill ;)

478 + if (parser.load_from_stream (file.read (null)))

Could you add a huge FIXME to make it async?

553 + preview_uri_map.insert (uri.substring (7), details_uri);

And another comment explaining why 7 (u1ms://)?

745 + app.release();

Perhaps add a bool flag, so we don't call release multiple times from here?

1024 + public abstract async void pause () throws IOError;
1025 + public abstract async void pause_resume () throws IOError;
1026 + public abstract async void resume () throws IOError;

Do we really need 3 methods? Would one play_pause() suffice?

1259 + var show_folder_action = new Unity.PreviewAction ("show_in_folder", _("Show in Folder "), null);
1286 + var show_folder_action = new Unity.PreviewAction ("show_in_folder", _("Show in Folder "), null);

Extra space in the title.

911 + timer_id = GLib.Timeout.add_seconds (1, progress_report_cb);

Looks like this timer isn't removed when it needs to be, I saw it keep firing and spamming dbus long after the song finished.

There's also the issue that sorting of songs vs albums is broken now in trunk, although not fault of this branch, we should fix that asap.

1310 + var show_folder_action = new Unity.PreviewAction ("show_in_folder", _("Show in Folder "), null);

Still extra space.

848 + gst_pipeline.set_state (Gst.State.READY);

I'm no gstreamer expert, but is switching to ready state here ok? Did you get a chance to test how would this work with internet radio streams? (+ losing connection and other error conditions).

I also wonder if we need TrackState.ERROR, but not going to block on that, we could add that after FF.

Fixed extra space. I think setting state = READY on EOS is fine, as according to gstreamer docs READY resets all internal gstreamer states.

However, you made a good point about error scenarios; I did some testing trying to simulate network connectivity issues and we definitely need to handle ERROR messagea in gst_bus_message_cb. I'd however propose to merge what we have now and deal with this in a separate MP.

Agreed, we can deal with error conditions in a separate MP.

No commit message specified.

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-music/24/console reported an error when processing this lp:~stolowski/unity-lens-music/unity-lens-music.previews branch.
Not merging it.

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity-lens-music/25/console reported an error when processing this lp:~stolowski/unity-lens-music/unity-lens-music.previews branch.
Not merging it.