Qt bindings for libbamf

Merge lp://staging/~stolowski/bamf-qt/fix-bamfview-removal into lp://staging/bamf-qt

  1. fix-bamfview-removal
  2. Merge into trunk
Proposed by Paweł Stołowski
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 395
Merged at revision: 395
Proposed branch: lp://staging/~stolowski/bamf-qt/fix-bamfview-removal
Merge into: lp://staging/bamf-qt
Diff against target: 10 lines (+1/-1)
1 file modified
bamf-factory.cpp (+1/-1)
To merge this branch: bzr merge lp://staging/~stolowski/bamf-qt/fix-bamfview-removal
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Florian Boucault Pending
Review via email: mp+101919@code.staging.launchpad.net

Commit message

Don't delete BamfView sender object immediately in BamfFactory::OnViewClosed slot, as there may be more receipients of Closed() signal. This makes it impossible for unity-2d to react on Closed() signal. Use deleteLater() instead.

Description of the change

Don't delete BamfView sender object immediately in BamfFactory::OnViewClosed slot, as there
may be more receipients of Closed() signal. This makes it impossible for unity-2d to react on Closed() signal.
Use deleteLater() instead.

UNBLOCK

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Code makes sense and indeed fixes the problem. I'm waiting on global approving since we are on the middle of the release and we better confirm with Gerry what to do with this.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches