Percona XtraBackup moved to https://jira.percona.com/projects/PXB

Merge lp://staging/~stewart/percona-xtrabackup/xtrabackup-copyright-for-scripts into lp://staging/percona-xtrabackup/2.0

  1. xtrabackup-copyright-for-scripts
  2. Merge into 2.0
Proposed by Stewart Smith
Status: Rejected
Rejected by: Stewart Smith
Proposed branch: lp://staging/~stewart/percona-xtrabackup/xtrabackup-copyright-for-scripts
Merge into: lp://staging/percona-xtrabackup/2.0
Diff against target: 462 lines (+307/-0)
19 files modified
test/disabled/ib_include.sh (+17/-0)
test/experimental/xb_race_drop.sh (+16/-0)
test/inc/common.sh (+17/-0)
test/run.sh (+16/-0)
test/t/bug606981.sh (+16/-0)
test/t/ib_csm_csv.sh (+16/-0)
test/t/ib_incremental.sh (+16/-0)
test/t/ib_partition.sh (+16/-0)
test/t/ib_specialchar.sh (+16/-0)
test/t/xb_basic.sh (+16/-0)
test/t/xb_export.sh (+16/-0)
test/t/xb_incremental.sh (+16/-0)
test/t/xb_incremental_compressed.sh (+16/-0)
test/t/xb_parallel.sh (+16/-0)
test/t/xb_part_range.sh (+16/-0)
test/t/xb_partial.sh (+16/-0)
test/t/xb_stats.sh (+16/-0)
test/t/xb_stream.sh (+16/-0)
utils/build.sh (+17/-0)
To merge this branch: bzr merge lp://staging/~stewart/percona-xtrabackup/xtrabackup-copyright-for-scripts
Reviewer Review Type Date Requested Status
Valentine Gostev (community) Approve
Vadim Tkachenko Pending
Review via email: mp+55690@code.staging.launchpad.net

Description of the change

shell scripts also need copyright headers. We test this in one of our build tests for Drizzle (and it makes Debian packaging happy).

Please feel free to modify with correct dates if so needed, I've taken this from looking at xtrabackup.c copyright.

To post a comment you must log in.
Revision history for this message
Valentine Gostev (longbow) wrote :

looks ok for me

review: Approve
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Stewart, as you understand, they are not really standalone scripts. So bloating all test files with copyright headers does not make much sense to me.

If it causes problems with some automated checkers, we can remove the .sh suffix to not confuse them.

Revision history for this message
Stewart Smith (stewart) wrote :

While I understand that they're not really standalone, it does make our lives a bit easier in easily tracking who-owns-what as well as being able to easily track what is under what license (especially when in the source tree of something like Drizzle, which does have BSD parts). Clarity is a big plus for us, and it certainly makes Debian happy :)

Revision history for this message
Stewart Smith (stewart) wrote :

So, we should do something about this... maybe just 1 line (C) and 1 line license pointing to COPYING file in top dir?

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Would removing the .sh suffix work? Or do Drizzle build tests require every single file to have a copyright header?

Adding a couple of lines should not be a problem of course, but it looks weird to me to have copyright headers in tests. Probably because MySQL doesn't have them.

Revision history for this message
Stewart Smith (stewart) wrote :

On Mon, 22 Aug 2011 14:52:23 -0000, Alexey Kopytov <email address hidden> wrote:
> Would removing the .sh suffix work? Or do Drizzle build tests require
> every single file to have a copyright header?

That should work. Probably triggers the test because of the sh suffix.

--
Stewart Smith

Revision history for this message
Stewart Smith (stewart) wrote :

This will mostly go away with new test framework (kewpie), so going to reject this merge req and we can fix anything that comes out of it.

Unmerged revisions

243. By Stewart Smith

add copyright header to xb_stats.sh test

242. By Stewart Smith

add missing copyright headers to shell scripts (Drizzle build farm does a check for correct licenses in all possible source files)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches