Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://staging/~stewart/percona-server/bug1017192 into lp://staging/percona-server/5.5

  1. bug1017192
  2. Merge into 5.5
Proposed by Stewart Smith
Status: Work in progress
Proposed branch: lp://staging/~stewart/percona-server/bug1017192
Merge into: lp://staging/percona-server/5.5
Diff against target: 75 lines (+34/-4)
2 files modified
Percona-Server/mysql-test/t/percona_bug1017192.test (+30/-0)
Percona-Server/sql/sql_table.cc (+4/-4)
To merge this branch: bzr merge lp://staging/~stewart/percona-server/bug1017192
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Needs Information
Review via email: mp+122426@code.staging.launchpad.net

Description of the change

Fix: Server crashes in add_identifier on concurrent ALTER TABLE and SHOW ENGINE INNODB STATUS

Fix and test case comes from MariaDB. Without fix, test case (just about always) crashes.

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/481/

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) wrote :

MariaDB bug: https://mariadb.atlassian.net/browse/MDEV-364

Reply
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Stewart -

It needs a DBUG_SYNC testcase. Also the bug & fix needs an actual explanation. It seems that MariaDB don't have one neither.

review: Needs Fixing
Reply
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Also, is 5.1 affected?

review: Needs Information
Reply
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

I was told that MariaDB fixed it in a different way, rev. 3491 in 5.5. (did not verify this report).

Reply

Unmerged revisions

293. By Stewart Smith

Fix bug lp:1017192 Server crashes in add_identifier on concurrent ALTER TABLE and SHOW ENGINE INNODB STATUS

Fix and test comes from MariaDB: https://mariadb.atlassian.net/browse/MDEV-364

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches