Percona Server moved to https://jira.percona.com/projects/PS

Merge lp://staging/~stewart/percona-server/bug1012488 into lp://staging/percona-server/5.5

  1. bug1012488
  2. Merge into 5.5
Proposed by Stewart Smith
Status: Work in progress
Proposed branch: lp://staging/~stewart/percona-server/bug1012488
Merge into: lp://staging/percona-server/5.5
Diff against target: 12645 lines (+10373/-1867)
59 files modified
Percona-Server/plugin/percona-pam-for-mysql/.bzrignore (+1/-0)
Percona-Server/plugin/percona-pam-for-mysql/CMakeLists.txt (+2/-0)
Percona-Server/plugin/percona-pam-for-mysql/doc/Makefile (+9/-0)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/layout.html (+0/-499)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/searchbox.html (+0/-22)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/static/default.css_t (+0/-469)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/static/jquery.min.js (+0/-154)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/static/percona.com.css (+0/-271)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/static/percona.com.js (+0/-269)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/static/sidebar.js (+0/-151)
Percona-Server/plugin/percona-pam-for-mysql/doc/source/percona-theme/theme.conf (+0/-32)
Percona-Server/plugin/percona-pam-for-mysql/src/auth_pam_common.h (+4/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/bootstrap.sh (+122/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/conf.py (+216/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/dbqp.rst (+21/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/index.rst (+34/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/kewpie.rst (+498/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/make.bat (+170/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/randgen.rst (+202/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/sql-bench.rst (+182/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/sysbench.rst (+123/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/test-run.rst (+494/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/docs/writing_tests.rst (+100/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/kewpie.py (+131/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/dtr/dtr_test_execution.py (+139/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/dtr/dtr_test_management.py (+495/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/native/native_test_execution.py (+100/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/native/native_test_management.py (+201/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/sysbench/sysbench_test_execution.py (+162/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/sysbench/sysbench_test_management.py (+159/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/modes/test_mode.py (+68/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/opts/defaults.py (+119/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/opts/matrix_manager.py (+51/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/opts/test_run_options.py (+575/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/server_mgmt/drizzled.py (+236/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/server_mgmt/galera.py (+359/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/server_mgmt/mysqld.py (+506/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/server_mgmt/percona.py (+287/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/server_mgmt/server.py (+382/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/server_mgmt/server_management.py (+507/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/codeTree.py (+489/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/code_management.py (+116/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/environment_management.py (+99/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/logging_management.py (+157/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/port_management.py (+196/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/system_management.py (+555/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/sys_mgmt/time_management.py (+118/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/test_mgmt/execution_management.py (+142/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/test_mgmt/test_execution.py (+325/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/test_mgmt/test_management.py (+300/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/util/crashme_methods.py (+127/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/util/mysqlBaseTestCase.py (+377/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/util/mysql_methods.py (+258/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/util/randgen_methods.py (+55/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/util/sqlbench_methods.py (+70/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/lib/util/xtrabackup_methods.py (+109/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/percona_tests/percona_pam/pam_basic_test.py (+112/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/percona_tests/percona_pam/pam_negative_test.py (+112/-0)
Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid (+1/-0)
To merge this branch: bzr merge lp://staging/~stewart/percona-server/bug1012488
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Needs Fixing
Review via email: mp+112280@code.staging.launchpad.net

Description of the change

Update the bundled PAM plugin to latest PAM plugin BZR tree.

basically this adds the test suite and an OSX build fix.

http://jenkins.percona.com/job/percona-server-5.5-param/443/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sigh, kewpie again. Thanks to wonderful the idea of merging kewpie to every individual project, we now have a bunch of sysbench-related code, randgen-related code, xtrabackup-related code in plugin/percona-pam-for-mysql/test.

All of that is because of 2 rudementary tests pam_negative_test.py and pam_basic_test.py. There's absolutely no reason to base them on kewpie. Apparently there was also an attempt to use the XtraBackup test suite, because there's also plugin/percona-pam-for-mysql/test/bootstrap.sh which is a verbatim copy from the XtraBackup tree and is unused in PAM plugin tests.

There's also the following WTF thing:

=== added directory 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data'
=== added file 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid'
--- Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid 1970-01-01 00:00:00 +0000
+++ Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid 2012-02-22 21:56:10 +0000
@@ -0,0 +1 @@
+e5f64ede-8707-4589-9c7a-fc598c0e2f6f
\ No newline at end of file

=== added symlink 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/workdir'
=== target is u'/dev/shm/qp_workdir_root_e5f64ede-8707-4589-9c7a-fc598c0e2f6f'

This has to be fixed 'upstream' before merging this into the server tree.

review: Needs Fixing
Reply
Revision history for this message
Stewart Smith (stewart) wrote :

Alexey Kopytov <email address hidden> writes:
> All of that is because of 2 rudementary tests pam_negative_test.py and
> pam_basic_test.py. There's absolutely no reason to base them on
> kewpie. Apparently there was also an attempt to use the XtraBackup
> test suite, because there's also
> plugin/percona-pam-for-mysql/test/bootstrap.sh which is a verbatim
> copy from the XtraBackup tree and is unused in PAM plugin tests.

Kewpie still needs a server to run, and bootstrap.sh is used to fetch it
(unless you're building a PS tree, in which case you can use that).

> There's also the following WTF thing:
>
> === added directory 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data'
> === added file 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid'
> --- Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid 1970-01-01 00:00:00 +0000
> +++ Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/qp_data/uuid 2012-02-22 21:56:10 +0000
> @@ -0,0 +1 @@
> +e5f64ede-8707-4589-9c7a-fc598c0e2f6f
> \ No newline at end of file
>
> === added symlink 'Percona-Server/plugin/percona-pam-for-mysql/test/dbqp/workdir'
> === target is u'/dev/shm/qp_workdir_root_e5f64ede-8707-4589-9c7a-fc598c0e2f6f'
>
> This has to be fixed 'upstream' before merging this into the server tree.

Yep, these shouldn't be there.

--
Stewart Smith

Reply
Revision history for this message
Alexey Kopytov (akopytov) wrote :

On 09.07.12 9:28, Stewart Smith wrote:
> Alexey Kopytov <email address hidden> writes:
>> All of that is because of 2 rudementary tests pam_negative_test.py and
>> pam_basic_test.py. There's absolutely no reason to base them on
>> kewpie. Apparently there was also an attempt to use the XtraBackup
>> test suite, because there's also
>> plugin/percona-pam-for-mysql/test/bootstrap.sh which is a verbatim
>> copy from the XtraBackup tree and is unused in PAM plugin tests.
>
> Kewpie still needs a server to run, and bootstrap.sh is used to fetch it
> (unless you're building a PS tree, in which case you can use that).

Well, in this case we do build in a PS tree.

Besides, bootstrap.sh is a verbatim copy from the XB tree, so I wonder
how it's arguments (innodb51, xtradb51, etc.) apply here.

Reply

Unmerged revisions

275. By Stewart Smith

merge latest PAM plugin sources

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches