Merge lp://staging/~stewart/percona-server/bug1011047 into lp://staging/percona-server/5.5
Proposed by
Stewart Smith
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~stewart/percona-server/bug1011047 |
| Merge into: | lp://staging/percona-server/5.5 |
| Diff against target: |
235 lines (+187/-5) 5 files modified
Percona-Server/mysql-test/include/have_example_plugin.inc (+2/-2) Percona-Server/mysql-test/r/percona_plugin_with_userstats.result (+65/-0) Percona-Server/mysql-test/t/percona_plugin_with_userstats-master.opt (+2/-0) Percona-Server/mysql-test/t/percona_plugin_with_userstats.test (+115/-0) Percona-Server/sql/mysqld.cc (+3/-3) |
| To merge this branch: | bzr merge lp://staging/~stewart/percona-server/bug1011047 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Laurynas Biveinis (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
Fix "can't start server with plugins loaded" bug. Basically, we were initing the userstats features too late.
http://
To post a comment you must log in.
Revision history for this message
| Laurynas Biveinis (laurynas-biveinis) wrote | # |
review:
Needs Fixing
Unmerged revisions
- 294. By Stewart Smith
-
Add a test for server not starting with userstats enabled/plugin installed (bug lp:1011047)
- 293. By Stewart Smith
-
fix bug: 'mysqld can't startup when a plugin was installed'. table and index statistics were inited too late, they instead need to be inited *before* plugins.
- 292. By Stewart Smith
-
fix mysql-test/
include/ have_example_ plugin. inc so that it's compatible with MTRv2 and detects EXAMPLE_PLUGIN_OPT instead of EXAMPLE_PLUGIN.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Stewart -
1) Can you reconcile your have_example_
2) Why a simple --source include/
3) Line 98 has "Edit" at the end, a copy paste from somewhere?