Merge lp://staging/~stewart/drizzle/warning-stack-frame-32k into lp://staging/drizzle/7.0

Proposed by Stewart Smith
Status: Merged
Merge reported by: Lee Bieber
Merged at revision: not available
Proposed branch: lp://staging/~stewart/drizzle/warning-stack-frame-32k
Merge into: lp://staging/drizzle/7.0
Diff against target: 1095 lines (+194/-130)
20 files modified
client/drizzle.cc (+5/-4)
client/drizzleslap.cc (+5/-2)
examples/pipe_query.c (+15/-8)
examples/proxy.c (+22/-18)
examples/server.c (+14/-11)
examples/simple.c (+12/-11)
examples/simple_multi.c (+11/-3)
examples/sqlite_server.c (+28/-24)
m4/pandora_warnings.m4 (+1/-1)
plugin/archive/archive_performance.cc (+5/-2)
plugin/archive/archive_reader.cc (+7/-3)
plugin/archive/archive_test.cc (+9/-2)
plugin/archive/concurrency_test.cc (+5/-2)
plugin/archive/ha_archive.cc (+27/-26)
plugin/innobase/row/row0merge.c (+6/-2)
plugin/logging_gearman/logging_gearman.cc (+4/-3)
plugin/myisam/ha_myisam.cc (+3/-1)
plugin/myisam/mi_open.cc (+6/-2)
plugin/pbms/src/backup_ms.cc (+5/-3)
plugin/pbms/src/trans_log_ms.cc (+4/-2)
To merge this branch: bzr merge lp://staging/~stewart/drizzle/warning-stack-frame-32k
Reviewer Review Type Date Requested Status
Drizzle Developers Pending
Review via email: mp+40325@code.staging.launchpad.net

Description of the change

Fixes up all methods with stack usage > 32k to use less than 32kb of stack.

Before this can be merged, Monty needs to fix up a check in pandora for the GCC warning, as the GCC version on hades is old enough not to have the wonderful option.

http://hudson.drizzle.org/view/Drizzle-param/job/drizzle-param/594/

To post a comment you must log in.
Revision history for this message
Andrew Hutchings (linuxjedi) wrote :

I don't know if it matters, but apparently auto_ptr is deprecated for C++0x. I suspect when that happens this will generate some kind of warning:

http://en.wikipedia.org/wiki/Auto_ptr

Revision history for this message
Monty Taylor (mordred) wrote :

I included this in my branch: lp:~mordred/drizzle/warning-stack-frame

Revision history for this message
Monty Taylor (mordred) wrote :

And yes - we should not be using auto_ptr, but instead should be using boost::scoped_ptr or boost::shared_ptr.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches