Drizzle

Merge lp://staging/~stewart/drizzle/dead-index-type-removal-from-proto into lp://staging/~drizzle-trunk/drizzle/development

  1. dead-index-type-removal-from-proto
  2. Merge into development
Proposed by Stewart Smith
Status: Rejected
Rejected by: Stewart Smith
Proposed branch: lp://staging/~stewart/drizzle/dead-index-type-removal-from-proto
Merge into: lp://staging/~drizzle-trunk/drizzle/development
Diff against target: 13 lines (+0/-2)
1 file modified
drizzled/message/table.proto (+0/-2)
To merge this branch: bzr merge lp://staging/~stewart/drizzle/dead-index-type-removal-from-proto
Reviewer Review Type Date Requested Status
Jay Pipes (community) Disapprove
Brian Aker Needs Information
Review via email: mp+15797@code.staging.launchpad.net

This proposal supersedes a proposal from 2009-12-08.

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) wrote : Posted in a previous version of this proposal

trivial fix. RTREE and FULLTEXT weren't completely removed.

Revision history for this message
Stewart Smith (stewart) wrote :

RTREE and FULLTEXT weren't removed from table proto.

Revision history for this message
Brian Aker (brianaker) wrote :

Should we do this? AKA we don't support them but we might. If we are going to remove them, shouldn't we renumber across the system?

review: Needs Information
Revision history for this message
Jay Pipes (jaypipes) wrote :

I see no benefit to removing these. We may (or plugin devs may) in the future support these, and more index types (like, say, FRACTAL_TREE)

review: Disapprove

Unmerged revisions

1241. By Stewart Smith

remove RTREE and FULLTEXT index types from table proto definition

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'drizzled/message/table.proto'
2--- drizzled/message/table.proto 2009-11-16 02:35:17 +0000
3+++ drizzled/message/table.proto 2009-12-08 04:05:22 +0000
4@@ -150,9 +150,7 @@
5 /* Kept in sync with enum ha_key_alg if only for stewart's sanity. */
6 UNKNOWN_INDEX = 0;
7 BTREE = 1;
8- RTREE = 2;
9 HASH = 3;
10- FULLTEXT = 4;
11 }
12
13 message IndexPart {