Merge lp://staging/~stewart/drizzle/bug751191 into lp://staging/~drizzle-trunk/drizzle/development
Proposed by
Stewart Smith
| Status: | Work in progress |
|---|---|
| Proposed branch: | lp://staging/~stewart/drizzle/bug751191 |
| Merge into: | lp://staging/~drizzle-trunk/drizzle/development |
| Diff against target: |
103 lines (+13/-5) 5 files modified
drizzled/main.cc (+6/-0) drizzled/open_tables_state.h (+2/-1) drizzled/session.cc (+2/-1) drizzled/sql_base.cc (+2/-2) plugin/signal_handler/signal_handler.cc (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~stewart/drizzle/bug751191 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Drizzle Merge Team | Pending | ||
|
Review via email:
|
|||
Description of the change
protect g_refresh_version from races by making it atomic.
http://
To post a comment you must log in.
Revision history for this message
| Brian Aker (brianaker) wrote | # |
Revision history for this message
| Stewart Smith (stewart) wrote | # |
Unmerged revisions
- 2344. By Stewart Smith
-
global g_refresh_version wasn't protected against races. Make it an atomic variable.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
We need a test case to show this bug. Refresh works based on a lossy view of the value.
Turning this to atomic will directly effect performance (I know, I once did this patch wondering about refresh).
Really? We need to get rid of refresh entirely.