Drizzle

Merge lp://staging/~stewart/drizzle/bug728260 into lp://staging/drizzle/7.0

bug728260
Merge into 7.0

Proposed by Stewart Smith on 2011-03-03

Status:

Rejected

Rejected by:

Stewart Smith on 2012-02-13

Proposed branch:

lp://staging/~stewart/drizzle/bug728260

Merge into:

lp://staging/drizzle/7.0

Diff against target:

28 lines (+0/-7)

2 files modified

drizzled/alter_info.h (+0/-1)
drizzled/sql_yacc.yy (+0/-6)

To merge this branch:

bzr merge lp://staging/~stewart/drizzle/bug728260

Low

Won't Fix

Link a bug report

Reviewer	Review Type	Date Requested	Status
Drizzle Developers		2011-03-03	Pending
Review via email: mp+52014@code.staging.launchpad.net

Description of the change

remove useless part of ALTER TABLE syntax that has done nothing since MySQL 5.1.42

Revision history for this message

Brian Aker (brianaker) wrote on 2011-03-03:

This does rebuild a table which could be damaged (ie this is used for Innodb, and of course MyISAM).

Revision history for this message

Stewart Smith (stewart) wrote on 2011-03-03:

this could also be done by ALTER TABLE .. ORDER BY pkey or another key that is less damaged - giving more control.

It's also undocumented, and has been undocumented for a long time.

Revision history for this message

Brian Aker (brianaker) wrote on 2011-03-03:

What if the user doesn't have a primary key? Making a user go through the sort code (which then makes an additional copy of the table) seems like a lot of work.

Let's just document this, there is a good reason this exists.

Unmerged revisions

2216. By Stewart Smith on 2011-03-03: remove the FORCE clause from ALTER TABLE. Previously you could do ALTER TABLE t1 FORCE - which ended up doing nothing useful at all. This has done nothing since MySQL 5.1.42 (at least)