Merge ~steverydz/maas:settings-page-indicator into maas:master
Proposed by
Steve Rydz
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Steve Rydz | ||||
| Approved revision: | 35caba764032da3c8149ad4f9977144f9934ddce | ||||
| Merge reported by: | MAAS Lander | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | ~steverydz/maas:settings-page-indicator | ||||
| Merge into: | maas:master | ||||
| Diff against target: |
349 lines (+214/-83) 2 files modified
src/maasserver/templates/maasserver/navigation.html (+208/-83) src/maasserver/views/settings.py (+6/-0) |
||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Blake Rouse (community) | Approve | ||
| Anthony Dillon | Approve | ||
|
Review via email:
|
|||
Commit message
LP: #1826280 - Add nav highlight to settings
Description of the change
QA steps:
- Go to settings
- Click through each tab in settings
- See that whilst within the settings page there is an orange line underneath settings in the navigation indicating you are on that page
To post a comment you must log in.
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM +1