snapweb

Merge lp://staging/~stevenwilkin/snapweb/snapcraft into lp://staging/~snappy-dev/snapweb/trunk

  1. snapcraft
  2. Merge into trunk
Proposed by Steven Wilkin
Status: Needs review
Proposed branch: lp://staging/~stevenwilkin/snapweb/snapcraft
Merge into: lp://staging/~snappy-dev/snapweb/trunk
Diff against target: 249 lines (+51/-147)
6 files modified
Makefile (+18/-0)
README.md (+5/-14)
build.sh (+0/-88)
pkg/meta/snap.yaml (+0/-21)
pkg/snappyd (+0/-24)
snapcraft.yaml (+28/-0)
To merge this branch: bzr merge lp://staging/~stevenwilkin/snapweb/snapcraft
Reviewer Review Type Date Requested Status
Snappy Developers Pending
Review via email: mp+296633@code.staging.launchpad.net

Commit message

Use Snapcraft to build the snap

Description of the change

Use Snapcraft to build the snap.

This should allow us to get LP to build and upload to the store for the range of supported architectures.

For the time being this is using a Makefile but if/when Snapcraft plugins appear which support godeps and gulp then things could be made simpler again.

To post a comment you must log in.
lp://staging/~stevenwilkin/snapweb/snapcraft updated
197. By Steven Wilkin <email address hidden>

Use `install` to move `snappyd` into destination dir

Revision history for this message
Steven Wilkin (stevenwilkin) wrote :

Updated with Zygmunt's advice to use `install` rather than `cp`

Reply
Revision history for this message
Steven Wilkin (stevenwilkin) wrote :

Kyle has pointed out that LP only enables network access during snapcraft's `pull` step. The approach in this MP is to pull down the dependencies during the `build` step which means LP won't be able to build the snap correctly.

We can either fold this in now and I can work on a follow-up MP containing a local plugin to handle the dependencies or we can wait until the plugin is created first.

Reply

Unmerged revisions

197. By Steven Wilkin <email address hidden>

Use `install` to move `snappyd` into destination dir

196. By Steven Wilkin <email address hidden>

Use Snapcraft to build snap

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches