Merge lp://staging/~stevenwilkin/snapweb/remove-snap-details-tabs into lp://staging/~snappy-dev/snapweb/trunk
Proposed by
Steven Wilkin
| Status: | Merged |
|---|---|
| Approved by: | Steven Wilkin |
| Approved revision: | 194 |
| Merged at revision: | 193 |
| Proposed branch: | lp://staging/~stevenwilkin/snapweb/remove-snap-details-tabs |
| Merge into: | lp://staging/~snappy-dev/snapweb/trunk |
| Diff against target: |
275 lines (+13/-162) 12 files modified
www/src/js/controllers/snaps.js (+2/-3) www/src/js/routers/router.js (+1/-1) www/src/js/templates/snap-detail.hbs (+0/-9) www/src/js/templates/snap-layout.hbs (+10/-2) www/src/js/templates/snap-menu.hbs (+0/-11) www/src/js/templates/snap-reviews.hbs (+0/-1) www/src/js/templates/snap-settings.hbs (+0/-1) www/src/js/views/snap-detail.js (+0/-11) www/src/js/views/snap-layout.js (+0/-60) www/src/js/views/snap-menu.js (+0/-40) www/src/js/views/snap-reviews.js (+0/-12) www/src/js/views/snap-settings.js (+0/-11) |
| To merge this branch: | bzr merge lp://staging/~stevenwilkin/snapweb/remove-snap-details-tabs |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Steven Wilkin (community) | Approve | ||
| Bartek Szopka (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Remove tabbed content for snap details page
Description of the change
Remove tabbed content for snap details page.
The new design doesn't include the tabbed sections in the snap details page. I think we can safely remove these now ahead of time. This is what the resulting pages looks like:
To post a comment you must log in.
Revision history for this message
| Snappy Tarmac (snappydevtarmac) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM, other tabs were empty anyway.