snapweb

Merge lp://staging/~stevenwilkin/snapweb/new-header into lp://staging/~stevenwilkin/snapweb/redesign

  1. new-header
  2. Merge into redesign
Proposed by Steven Wilkin
Status: Needs review
Proposed branch: lp://staging/~stevenwilkin/snapweb/new-header
Merge into: lp://staging/~stevenwilkin/snapweb/redesign
Diff against target: 867 lines (+294/-233)
19 files modified
cmd/snappyd/handlers.go (+27/-14)
cmd/snappyd/handlers_test.go (+59/-0)
dependencies.tsv (+1/-1)
gulpfile.js (+3/-0)
package.json (+2/-0)
snappy/common_test.go (+1/-45)
snappy/converge.go (+2/-2)
snappy/converge_test.go (+11/-11)
snappy/fake_snapd_client.go (+79/-0)
snappy/handlers.go (+4/-4)
snappy/handlers_test.go (+4/-4)
snappy/icon.go (+1/-1)
snappy/icon_test.go (+2/-2)
snappy/snapd_client.go (+4/-2)
statustracker/statustracker.go (+1/-1)
statustracker/statustracker_test.go (+1/-1)
www/src/css/banner.css (+71/-110)
www/src/js/templates/layout-banner.hbs (+18/-33)
www/templates/base.html (+3/-2)
To merge this branch: bzr merge lp://staging/~stevenwilkin/snapweb/new-header
Reviewer Review Type Date Requested Status
Steven Wilkin Pending
Review via email: mp+295574@code.staging.launchpad.net

Commit message

Apply new design to header

Description of the change

Apply new design to header.

I'll provide additional information via email to relevant parties.

To post a comment you must log in.
Revision history for this message
Bartek Szopka (bartoszopka) wrote :

Hi Steven,

Thanks for this first MP.
I made couple of comments inline about my concerns - they are mostly around how vanilla is imported and the usage of !important in CSS.

These are more questions at this point than things to fix, as I'm trying to find a common ground between this webdm redesign work and our current OLS front-end practices.

Reply
Revision history for this message
Steven Wilkin (stevenwilkin) wrote :

Thanks for the feedback, there's a couple of action points around the importing of Vanilla I can address and the remainder belongs with the higher-level discussion.

Reply
lp://staging/~stevenwilkin/snapweb/new-header updated
192. By Steven Wilkin

Include most recent Vanilla and import via build.scss instead of globbing all files

193. By Steven Wilkin

Merge trunk

Revision history for this message
Steven Wilkin (stevenwilkin) wrote :

Now using most recent version of Vanilla and importing via it's build.scss

Reply

Unmerged revisions

193. By Steven Wilkin

Merge trunk

192. By Steven Wilkin

Include most recent Vanilla and import via build.scss instead of globbing all files

191. By Steven Wilkin

Apply new header design

190. By Steven Wilkin

Add the Vanilla CSS framework

https://github.com/ubuntudesign/vanilla-framework

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: