Merge lp://staging/~stevenwilkin/snapweb/get-snap-from-store into lp://staging/~snappy-dev/snapweb/trunk

Proposed by Steven Wilkin
Status: Needs review
Proposed branch: lp://staging/~stevenwilkin/snapweb/get-snap-from-store
Merge into: lp://staging/~snappy-dev/snapweb/trunk
Diff against target: 169 lines (+86/-6)
3 files modified
snappy/converge.go (+24/-3)
snappy/converge_test.go (+59/-2)
snappy/fake_snapd_client.go (+3/-1)
To merge this branch: bzr merge lp://staging/~stevenwilkin/snapweb/get-snap-from-store
Reviewer Review Type Date Requested Status
Snappy Developers Pending
Review via email: mp+296774@code.staging.launchpad.net

Commit message

Fallback to searching the store if snap not found locally

Description of the change

In the recent past a call to `/v2/snaps/<SNAP>` on the snapd API returned details of snaps available on the store if they weren't already installed locally. Now, this endpoint only returns details of snaps if they are already installed.

This change meant an error any time WebDM attempted to fetch the details of a not-yet-installed snap which includes installation and removal of snaps.

With this MP WebDM fallsback to a search of the store whenever retrieval of an individual snap fails.

To post a comment you must log in.

Unmerged revisions

197. By Steven Wilkin

Fallback to searching the store if snap not found locally

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches