Launchpad itself

Merge lp://staging/~stevenk/launchpad/xmlexport-all-specs into lp://staging/launchpad

  1. xmlexport-all-specs
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Steve Kowalik
Approved revision: no longer in the source branch.
Merged at revision: 16566
Proposed branch: lp://staging/~stevenk/launchpad/xmlexport-all-specs
Merge into: lp://staging/launchpad
Diff against target: 117 lines (+17/-23)
3 files modified
lib/lp/blueprints/browser/sprint.py (+6/-13)
lib/lp/blueprints/doc/sprint-meeting-export.txt (+10/-10)
lib/lp/blueprints/stories/sprints/xx-sprint-meeting-export.txt (+1/-0)
To merge this branch: bzr merge lp://staging/~stevenk/launchpad/xmlexport-all-specs
Reviewer Review Type Date Requested Status
William Grant (community) code Approve
Review via email: mp+159061@code.staging.launchpad.net

Commit message

No longer filter specifications by their definition status in Sprint:+temp-meeting-export.

Description of the change

This MP builds on work started by Steve Langasek in https://code.launchpad.net/~vorlon/launchpad/lp.994110/+merge/105078. I disagree with Curtis, in that sometimes you do want to discuss a spec at a sprint, no matter the definition status because you're not sure if it is going to worked on that series at all -- you have no idea at that point, so the filtering is actively harmful. I have also fixed tests.

I have also done a drive-by cleaning up the render() method to look cleaner, and have cleaned up the comments I saw to fit our guidelines.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.