Launchpad itself

Merge lp://staging/~stevenk/launchpad/no-oops-request-daily-build into lp://staging/launchpad

no-oops-request-daily-build
Merge into devel

Proposed by Steve Kowalik on 2012-08-15

Status:

Merged

Approved by:

Steve Kowalik on 2012-08-15

Approved revision:

no longer in the source branch.

Merged at revision:

15813

Proposed branch:

lp://staging/~stevenk/launchpad/no-oops-request-daily-build

Merge into:

lp://staging/launchpad

Diff against target:

194 lines (+65/-11)

5 files modified

lib/lp/code/browser/sourcepackagerecipe.py (+10/-2)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+18/-1)
lib/lp/code/interfaces/sourcepackagerecipe.py (+5/-1)
lib/lp/code/model/sourcepackagerecipe.py (+9/-2)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+23/-5)

To merge this branch:

bzr merge lp://staging/~stevenk/launchpad/no-oops-request-daily-build

Related bugs:

Bug #980384: series does not automatically go away on recipe builds when they go unsupported	Critical	Fix Released
Bug #1006493: OOPS when daily build targets unsupported distroeries	Critical	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Curtis Hovey (community)	code	2012-08-15	Approve on 2012-08-15
Review via email: mp+119654@code.staging.launchpad.net

Commit message

Skip obsolete series in ISourcePackageRecipe.performDailyBuild(), and warn users about them.

Description of the change

Currently, if you request a daily build of a recipe that contains an obsolete series (such as Maverick), you get an OOPS since the code raises a BuildNotAllowedForDistro exception, which is not caught.

I have changed ISourcePackageRecipe.performDailyBuild() to filter out distroseries which can't be built, and have added a helper method which the view calls to add a warning to the notification.

Also driveby a little cleanup.

Revision history for this message