Launchpad itself

Merge lp://staging/~stevenk/launchpad/dsd-dont-request-child-diff into lp://staging/launchpad

dsd-dont-request-child-diff
Merge into devel

Proposed by Steve Kowalik on 2011-04-01

Status:

Merged

Approved by:

Jeroen T. Vermeulen on 2011-04-01

Approved revision:

no longer in the source branch.

Merged at revision:

12736

Proposed branch:

lp://staging/~stevenk/launchpad/dsd-dont-request-child-diff

Merge into:

lp://staging/launchpad

Diff against target:

66 lines (+28/-4)

2 files modified

lib/lp/registry/model/distroseriesdifference.py (+3/-2)
lib/lp/registry/tests/test_distroseriesdifference.py (+25/-2)

To merge this branch:

bzr merge lp://staging/~stevenk/launchpad/dsd-dont-request-child-diff

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Jeroen T. Vermeulen (community)	code	2011-04-01	Approve on 2011-04-01
Review via email: mp+55863@code.staging.launchpad.net

Commit message

[r=jtv][bug=746201] Don't request a diff in DSD.requestDiff() if the child has the same version as the base.

Description of the change

Building on the work started in https://code.launchpad.net/~stevenk/launchpad/dsd-hide-child-diff/+merge/55685, this branch handles the backend case, by not even requesting a diff if the child has the base version as its latest version.

Revision history for this message

Jeroen T. Vermeulen (jtv) wrote on 2011-04-01:

Looks good. Comments as per IRC:
* The code is already clearing diffs on the child package if there was one previously and the new version number says there should no longer be one. Good.
* Typo: "dervied_changelog." You were consistent about it though. ☺
* Consider using the FakeLibrarian which can fake commits that are needed for the librarian only.

Jeroen

review: Approve (code)