Launchpad itself

Merge lp://staging/~stevenk/launchpad/delayed-ppa-copies-ancestryless into lp://staging/launchpad

  1. delayed-ppa-copies-ancestryless
  2. Merge into devel
Proposed by Steve Kowalik
Status: Merged
Approved by: Julian Edwards
Approved revision: no longer in the source branch.
Merged at revision: 12084
Proposed branch: lp://staging/~stevenk/launchpad/delayed-ppa-copies-ancestryless
Merge into: lp://staging/launchpad
Diff against target: 64 lines (+34/-9)
2 files modified
lib/lp/soyuz/model/publishing.py (+15/-9)
lib/lp/soyuz/tests/test_publishing.py (+19/-0)
To merge this branch: bzr merge lp://staging/~stevenk/launchpad/delayed-ppa-copies-ancestryless
Reviewer Review Type Date Requested Status
Julian Edwards (community) code Approve
Review via email: mp+43750@code.staging.launchpad.net

Commit message

[r=julian-edwards][ui=none][bug=610687] Change overrideFromAncestry() to not check ancestry for PPA uploads, and assert the component is sane.

Description of the change

This branch changes overrideFromAncestry() to not even check it for PPA uploads, and assert their component is 'main' for a sanity check.

I also drove-by a comment fix that I noticed.

To post a comment you must log in.
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Approved on the understanding that you fix the hard-coded check for 'main' and replace it with IArchive.getComponentsForSeries()

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.