linaro-license-protection

Merge lp://staging/~stevanr/linaro-license-protection/automate-integration-tests into lp://staging/~linaro-automation/linaro-license-protection/trunk

automate-integration-tests
Merge into trunk

Proposed by Stevan Radaković on 2012-05-09

Status:

Merged

Approved by:

James Tunnicliffe on 2012-05-11

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~stevanr/linaro-license-protection/automate-integration-tests

Merge into:

lp://staging/~linaro-automation/linaro-license-protection/trunk

Diff against target:

517 lines (+305/-143)

5 files modified

.htaccess (+2/-2)
README (+7/-0)
testing/filefetcher.py (+0/-129)
testing/license_protected_file_downloader.py (+284/-0)
testing/test_click_through_license.py (+12/-12)

To merge this branch:

bzr merge lp://staging/~stevanr/linaro-license-protection/automate-integration-tests

Related bugs:

Bug #996002: Integration tests fail

Critical

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
James Tunnicliffe (community)		2012-05-09	Approve on 2012-05-11
Данило Шеган	code	2012-05-09	Pending
Review via email: mp+105209@code.staging.launchpad.net

Description of the change

Update filefetcher to the newest version from James' branch.
Fix https://bugs.launchpad.net/linaro-license-protection/+bug/996002
Automate integration tests after deployment to production.

Revision history for this message

Stevan Radaković (stevanr) wrote on 2012-05-09:

Sorry guys, I accidentally did everything in one commit. I reverted file to James' version and pushed my new version again.

lp://staging/~stevanr/linaro-license-protection/automate-integration-tests updated on 2012-05-09

71. By Stevan Radaković on 2012-05-09: Reverting file so changes can be seen.
72. By Stevan Radaković on 2012-05-09: Done reverting file so changes can be seen.

Revision history for this message

Данило Шеган (danilo) wrote on 2012-05-10:

This would be a good opportunity to add a dependencies section to the 'Setup' section in the README (or if you have a better idea of where it should go, just go for it). Something along the following lines:

Dependencies
............

libapache2-mod-php5

Testing: phpunit, testrepository, python-html2text

Revision history for this message

Данило Шеган (danilo) wrote on 2012-05-10:

Also, tests are still not passing with these changes. Have you had a chance to investigate that?

lp://staging/~stevanr/linaro-license-protection/automate-integration-tests updated on 2012-05-11

73. By Stevan Radaković on 2012-05-10: Wrong identation fix in _get_license method
74. By Stevan Radaković on 2012-05-11: Incorrect parsing of the domain fixed
75. By Stevan Radaković on 2012-05-11: Tests updated to use new filefetcher

Revision history for this message

James Tunnicliffe (dooferlad) wrote on 2012-05-11:

I am working on the assumption that the tests pass now :-)

This looks fine. Please add the lines to README that Danilo suggested as well, but I don't think there is any reason to re-review with that change, so I will approve this. Of course, if you have other ideas for the set up instructions, then please just check in without that change.

review: Approve

lp://staging/~stevanr/linaro-license-protection/automate-integration-tests updated on 2012-05-11

76. By Stevan Radaković on 2012-05-11: Add Dependencies section to README file
77. By Stevan Radaković on 2012-05-11: Revert accidental commit of __init__.py