Merge lp://staging/~stevanr/linaro-image-tools/bug-1107784 into lp://staging/linaro-image-tools/11.11
Proposed by
Stevan Radaković
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Milo Casagrande | ||||
| Approved revision: | 613 | ||||
| Merged at revision: | 606 | ||||
| Proposed branch: | lp://staging/~stevanr/linaro-image-tools/bug-1107784 | ||||
| Merge into: | lp://staging/linaro-image-tools/11.11 | ||||
| Diff against target: |
3793 lines (+731/-701) 39 files modified
linaro_image_tools/hwpack/builder.py (+18/-18) linaro_image_tools/hwpack/config.py (+14/-13) linaro_image_tools/hwpack/handler.py (+6/-6) linaro_image_tools/hwpack/hardwarepack.py (+6/-6) linaro_image_tools/hwpack/hardwarepack_format.py (+3/-3) linaro_image_tools/hwpack/hwpack_convert.py (+20/-18) linaro_image_tools/hwpack/hwpack_fields.py (+4/-3) linaro_image_tools/hwpack/hwpack_reader.py (+9/-9) linaro_image_tools/hwpack/packages.py (+8/-8) linaro_image_tools/hwpack/tarfile_matchers.py (+3/-4) linaro_image_tools/hwpack/testing.py (+5/-6) linaro_image_tools/hwpack/tests/__init__.py (+1/-1) linaro_image_tools/hwpack/tests/test_builder.py (+30/-29) linaro_image_tools/hwpack/tests/test_config.py (+97/-97) linaro_image_tools/hwpack/tests/test_config_v3.py (+43/-41) linaro_image_tools/hwpack/tests/test_hardwarepack.py (+17/-17) linaro_image_tools/hwpack/tests/test_hwpack_converter.py (+29/-29) linaro_image_tools/hwpack/tests/test_hwpack_reader.py (+7/-7) linaro_image_tools/hwpack/tests/test_packages.py (+15/-16) linaro_image_tools/hwpack/tests/test_script.py (+1/-1) linaro_image_tools/hwpack/tests/test_tarfile_matchers.py (+3/-3) linaro_image_tools/hwpack/tests/test_testing.py (+4/-4) linaro_image_tools/media_create/__init__.py (+1/-1) linaro_image_tools/media_create/android_boards.py (+12/-12) linaro_image_tools/media_create/boards.py (+50/-44) linaro_image_tools/media_create/check_device.py (+2/-2) linaro_image_tools/media_create/chroot_utils.py (+3/-3) linaro_image_tools/media_create/partitions.py (+4/-3) linaro_image_tools/media_create/rootfs.py (+3/-3) linaro_image_tools/media_create/tests/__init__.py (+1/-1) linaro_image_tools/media_create/tests/test_android_boards.py (+19/-16) linaro_image_tools/media_create/tests/test_media_create.py (+242/-226) linaro_image_tools/tests/__init__.py (+2/-2) linaro_image_tools/tests/test_cmd_runner.py (+1/-1) linaro_image_tools/tests/test_pep8.py (+5/-4) linaro_image_tools/tests/test_pyflakes.py (+2/-2) linaro_image_tools/tests/test_utils.py (+18/-19) linaro_image_tools/utils.py (+10/-10) setup.py (+13/-13) |
||||
| To merge this branch: | bzr merge lp://staging/~stevanr/linaro-image-tools/bug-1107784 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Milo Casagrande (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Fix for bug #1107784.
Changes are fairly simple so it might not make sense to go through each of the lines individually, running tests on quantal should be enough.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hello Stevan!
Thanks for fixing all those PEP8 errors!
Everything looks good to me, I ran the tests on a 12.10 clean install, and I do not see any PEP8 tests failing. There are some that should be related to the command-not-found problem in another bug.
As far as this concerns PEP8, it looks good to me.