Merge lp://staging/~stevanr/linaro-ci-dashboard/lava-data-model into lp://staging/linaro-ci-dashboard

Proposed by Stevan Radaković
Status: Merged
Approved by: Milo Casagrande
Approved revision: 70
Merged at revision: 67
Proposed branch: lp://staging/~stevanr/linaro-ci-dashboard/lava-data-model
Merge into: lp://staging/linaro-ci-dashboard
Diff against target: 1160 lines (+873/-17)
24 files modified
Makefile (+3/-1)
dashboard/frontend/forms/loop_form.py (+5/-2)
dashboard/frontend/migrations/0007_auto__add_field_loopbuild_lava_test_status.py (+52/-0)
dashboard/frontend/migrations/0008_auto__add_field_loop_lava_tests.py (+53/-0)
dashboard/frontend/models/loop.py (+1/-0)
dashboard/frontend/models/loop_build.py (+3/-0)
dashboard/frontend/templates/lava_select.html (+23/-0)
dashboard/frontend/templates/lava_tests_list.html (+7/-0)
dashboard/frontend/templates/loop_detail.html (+2/-2)
dashboard/frontend/tests/test_models.py (+13/-6)
dashboard/frontend/urls.py (+6/-0)
dashboard/frontend/views/lava_select_test_names.py (+58/-0)
dashboard/frontend/views/lava_select_view.py (+46/-0)
dashboard/frontend/widgets/lava_test_select_widget.py (+45/-0)
dashboard/frontend/widgets/link_widget.py (+4/-4)
dashboard/js/lava/lava_test_select.js (+98/-0)
dashboard/lavaserver/lib/lavalib.py (+249/-0)
dashboard/lavaserver/migrations/0001_initial.py (+66/-0)
dashboard/lavaserver/models/__init__.py (+1/-0)
dashboard/lavaserver/models/lava.py (+37/-0)
dashboard/lavaserver/tests/__init__.py (+23/-0)
dashboard/lavaserver/tests/test_lavalib.py (+70/-0)
dashboard/settings.py (+4/-0)
dashboard/urls.py (+4/-2)
To merge this branch: bzr merge lp://staging/~stevanr/linaro-ci-dashboard/lava-data-model
Reviewer Review Type Date Requested Status
Milo Casagrande (community) Approve
Linaro Infrastructure Pending
Review via email: mp+126092@code.staging.launchpad.net

Description of the change

Stacked branch from https://code.launchpad.net/~milo/linaro-ci-dashboard/lava-data-model/+merge/125162 .
Includes more backend and UI refactorings as well as some additional functionalities like 'update' lava tests.
Lava backend is still not in place, test names are pulled as hard-coded values, but we should land this now and do those other tasks in separate branches.

To post a comment you must log in.
Revision history for this message
Stevan Radaković (stevanr) wrote :

You will notice I moved all the views, templates and widgets in the frontend app.
Lava app should basically only handle communication channel with LAVA server, not provide UI logic for the frontend.

69. By Stevan Radaković

Remove commented code.

70. By Stevan Radaković

Merge from trunk and remove conflicts.

Revision history for this message
Milo Casagrande (milo) wrote :

Hey Stevan, thanks for the awesome work! And the refactoring too.
It looks good to go.
+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches