Merge lp://staging/~stevanr/linaro-ci-dashboard/add_loop_type into lp://staging/linaro-ci-dashboard
Proposed by
Stevan Radaković
| Status: | Merged |
|---|---|
| Approved by: | Stevan Radaković |
| Approved revision: | 33 |
| Merge reported by: | Stevan Radaković |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~stevanr/linaro-ci-dashboard/add_loop_type |
| Merge into: | lp://staging/linaro-ci-dashboard |
| Diff against target: |
142 lines (+60/-3) 8 files modified
dashboard/frontend/android_build/forms/android_loop_form.py (+1/-1) dashboard/frontend/android_build/models/android_loop.py (+1/-0) dashboard/frontend/integration_loop/forms/integration_loop_form.py (+1/-1) dashboard/frontend/integration_loop/models/integration_loop.py (+1/-0) dashboard/frontend/kernel_build/forms/kernel_loop_form.py (+1/-1) dashboard/frontend/kernel_build/models/kernel_loop.py (+1/-0) dashboard/frontend/migrations/0003_auto__add_field_loop_type.py (+49/-0) dashboard/frontend/models/loop.py (+5/-0) |
| To merge this branch: | bzr merge lp://staging/~stevanr/linaro-ci-dashboard/add_loop_type |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Deepti B. Kalakeri (community) | code | Approve | |
| Milo Casagrande | Pending | ||
|
Review via email:
|
|||
Description of the change
Add the type attribute for Loop model as discussed on CI dashboard meeting.
I know it's a way to fast, but I really needed it on more then one occasion.
To post a comment you must log in.
Revision history for this message
| Stevan Radaković (stevanr) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think we can still retain Type to be displayed on the forms, it is not going to harm anyways and will give a bit of information as to which type of CI job we are trying to run.
Any specific reason for not having it ?
Otherwise looks good.