Merge lp://staging/~stevanr/linaro-android-frontend/textile-view into lp://staging/linaro-android-frontend

Forgot to mention, asac also wanted some of the UI thumbled around, so that's in as well with this MP.

-SERVER_JENKINS_URL = 'http://127.0.0.1:9090/jenkins/'
+SERVER_JENKINS_URL = 'http://127.0.0.1:10101/jenkins/'

This looks like debug changes or something to me, the same as r286 (i.e. these changes unlikely can be merged to trunk).

8 +def get_remote_file_content(request):
9 + try:
10 + return HttpResponse(urllib2.urlopen(request.GET['url']).read())
11 + except:
12 + return HttpResponse("Invalid argument")
13 +

What is being done here is establishing an open public proxy. Just imagine what it can, and will be, abused for - someone will download whole internets via it, others just pr0n or hack fbis. No go.

Just to manage that risk, there's also existing proxy_remote_file() function with the same intent, except that it zealously limits allowed URLs.

"Approve" is a 2nd message above is by mistake of course, I don't approve of hacking fbis ;-).

Didn't look in more detail so far, consider 2 issues above serious enough to be addressed first.

Looks good.

Don't forget to change back
+SERVER_JENKINS_URL = 'http://127.0.0.1:10101/jenkins/'

and
+ var downloadUrl = 'http://staging.snapshots.linaro.org/android/' + rawBuildName + '/' + results.number.toString() + '/';
+ handleRenderedFiles(downloadUrl);

and I suppose the commented lines are unnecessary:
213, 216, 218, 220, 221

Another comment I would have is that Android frontend was written using YUI JavaScript framework library. Bringing in another framework library like jQuery is questionable systems design action. I can't really be "against" this, because I'd prefer to use jQuery myself (on the other hand, I was once explained why YUI was used there - it turned out it's kinda standard/best practice to use it in Canonical).

Otherwise, UI as present at https://ec2-23-20-244-116.compute-1.amazonaws.com/builds/~gesha/staging-publishing-test/ seems to be designed and implemented fine.

So, I consider 2 issues raised above critical, but once fixes, approve from me.

Thanks for fixing those!

Approved.

One note though:

    allowed_hosts = ["https?://snapshots.linaro.org/",
284
284
                     "https?://android-build.linaro.org"]

Maybe we want to add staging.snapshots.linaro.org there right away.