LAVA Dashboard (deprecated)

Merge lp://staging/~stevanr/lava-dashboard/image-reports-feedback into lp://staging/lava-dashboard

image-reports-feedback
Merge into trunk

Proposed by Stevan Radaković on 2013-06-18

Status:	Merged
Approved by:	Stevan Radaković on 2013-06-18
Approved revision:	412
Merged at revision:	408
Proposed branch:	lp://staging/~stevanr/lava-dashboard/image-reports-feedback
Merge into:	lp://staging/lava-dashboard
Diff against target:	210 lines (+92/-11) 3 files modified dashboard_app/static/dashboard_app/css/image-report.css (+8/-1) dashboard_app/static/dashboard_app/js/image-report.js (+73/-2) dashboard_app/templates/dashboard_app/image-report.html (+11/-8)
To merge this branch:	bzr merge lp://staging/~stevanr/lava-dashboard/image-reports-feedback
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Antonio Terceiro		2013-06-18	Approve on 2013-06-18
Review via email: mp+170074@code.staging.launchpad.net

Description of the change

* Table cell width when there are bugs linked
* Switch graph on/off checkbox(on by default)
* would like to be able to share a link to the images, timeline, etc..

Revision history for this message

Antonio Terceiro (terceiro) wrote on 2013-06-18:

Looks good to me.

On update_filter_link(), are we sure that all the values used to compose the URL don't need escaping?

review: Approve

Revision history for this message

Stevan Radaković (stevanr) wrote on 2013-06-18:

> Looks good to me.
>
> On update_filter_link(), are we sure that all the values used to compose the
> URL don't need escaping?

The only value that can need the unescaping would be "target goal" but that would mean an invalid value is entered in which case we ignore the field anyway. I'll add the unescaping part anyway, thanks. I'll think of adding the check for a numeric value in that field as well.

lp://staging/~stevanr/lava-dashboard/image-reports-feedback updated on 2013-06-18

412. By Stevan Radaković on 2013-06-18: Add unescaping and trimming for target goal field. Add validation check for invalid values of target goal.