Merge lp://staging/~stephen-stewart/ubuntu-webcatalog/unfubar-js into lp://staging/ubuntu-webcatalog
Proposed by
Stephen Stewart
| Status: | Merged |
|---|---|
| Approved by: | Stephen Stewart |
| Approved revision: | 189 |
| Merged at revision: | 189 |
| Proposed branch: | lp://staging/~stephen-stewart/ubuntu-webcatalog/unfubar-js |
| Merge into: | lp://staging/ubuntu-webcatalog |
| Diff against target: |
133 lines (+43/-39) 6 files modified
src/webcatalog/templates/webcatalog/application_detail.html (+5/-0) src/webcatalog/templates/webcatalog/exhibits_widget.html (+0/-12) src/webcatalog/templates/webcatalog/featured_apps_widget.html (+0/-12) src/webcatalog/templates/webcatalog/index.html (+38/-0) src/webcatalog/templates/webcatalog/screenshot_widget.html (+0/-3) src/webcatalog/templates/webcatalog/top_rated_apps_widget.html (+0/-12) |
| To merge this branch: | bzr merge lp://staging/~stephen-stewart/ubuntu-webcatalog/unfubar-js |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jonas G. Drange (community) | Approve | ||
| Michael Nelson (community) | Approve | ||
|
Review via email:
|
|||
Commit message
move js to end of document
Description of the change
move js to end of page, fixing errors with carousels being called before yui was loaded (caused by global nav change)
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 LGTM. I think Jonas is bootstrapping to run it too.