Merge lp://staging/~stephen-j-boddy/terminator/bugfix-lp-406754 into lp://staging/terminator/trunk

Proposed by Stephen Boddy
Status: Merged
Merged at revision: 1317
Proposed branch: lp://staging/~stephen-j-boddy/terminator/bugfix-lp-406754
Merge into: lp://staging/terminator/trunk
Diff against target: 120 lines (+52/-8)
3 files modified
doc/terminator.1 (+12/-0)
terminatorlib/optionparse.py (+4/-0)
terminatorlib/window.py (+36/-8)
To merge this branch: bzr merge lp://staging/~stephen-j-boddy/terminator/bugfix-lp-406754
Reviewer Review Type Date Requested Status
Chris Jones (community) Approve
Review via email: mp+112598@code.staging.launchpad.net

Description of the change

As well as fixing the window name, I also added logic to set the window icon. I did it here because it also tries setting the icon based on the window class name.

Finally, while I was editing the man page I noticed a couple of options missing that were in the --help output, so I added those too.

It's all fairly minor stuff anyway.

To post a comment you must log in.
Revision history for this message
Chris Jones (cmsj) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.