Merge lp://staging/~stefankrupop/maas/recs into lp://staging/~maas-committers/maas/trunk
Status: | Merged |
---|---|
Approved by: | Newell Jensen |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6103 |
Proposed branch: | lp://staging/~stefankrupop/maas/recs |
Merge into: | lp://staging/~maas-committers/maas/trunk |
Diff against target: |
1092 lines (+932/-15) 8 files modified
src/maasserver/api/machines.py (+14/-11) src/maasserver/api/tests/test_machines.py (+7/-4) src/maasserver/static/js/angular/controllers/add_hardware.js (+38/-0) src/provisioningserver/drivers/power/recs.py (+345/-0) src/provisioningserver/drivers/power/registry.py (+2/-0) src/provisioningserver/drivers/power/tests/test_recs.py (+465/-0) src/provisioningserver/rpc/clusterservice.py (+7/-0) src/provisioningserver/rpc/tests/test_clusterservice.py (+54/-0) |
To merge this branch: | bzr merge lp://staging/~stefankrupop/maas/recs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Newell Jensen (community) | Approve | ||
Stefan Krupop (community) | Needs Resubmitting | ||
Mike Pontillo (community) | Needs Information | ||
Review via email:
|
Commit message
adds power management support for christmann RECS|Box servers (https:/
Description of the change
This branch adds power management support for christmann RECS|Box servers (https:/
Currently, trying to add a chassis via the WebGUI runs into bug #1572060 (https:/
Originally, I developed the change last year against some older MAAS version and based it on the Seamicro 15k driver. As I am normally not a Python developer, I hope I did not mess up the update too much. Please bear with me ;)
Thanks for your contribution. Unfortunately there is legal due diligence that must happen before we can consider merging your work. Would you please follow the instructions here in order to sign our contributor agreement?
https:/ /www.ubuntu. com/legal/ contributors
We would be happy to consider your contributions after the agreement is in place.
With regard to the code, (since Python is an interpreted language) the MAAS team coding standards require that each line of code be covered by unit tests. If you look in the `tests/` directory you should find `test_*.py` files that roughly correspond to the Python source in `../*.py`. That is us to accept this proposal, you would need to amend the tests for any files that have changed, and also create a new test file for your new driver.
As an aside, it would be tricky for the MAAS team to officially support this type of server, since we do not have test hardware that would allow us to ensure that your contribution works in the future, as more changes are made to MAAS and/or the RECS|Box APIs. I don't think we should block your contribution based on that, but this is also something that deserves discussion; perhaps our organizations' respective business development teams should talk to see if we can better collaborate.