Qreator

Merge lp://staging/~stefan-schwarzburg/qreator/qreator_window_height into lp://staging/qreator

  1. qreator_window_height
  2. Merge into trunk
Proposed by Schwarzburg
Status: Merged
Approved by: David Planella
Approved revision: 136
Merged at revision: 136
Proposed branch: lp://staging/~stefan-schwarzburg/qreator/qreator_window_height
Merge into: lp://staging/qreator
Diff against target: 11 lines (+1/-0)
1 file modified
qreator/QreatorWindow.py (+1/-0)
To merge this branch: bzr merge lp://staging/~stefan-schwarzburg/qreator/qreator_window_height
Reviewer Review Type Date Requested Status
David Planella Approve
Review via email: mp+133802@code.staging.launchpad.net

Description of the change

This is just the extracted bug fix from the SMS branch which keeps the main window from growing with each qrtype.

Not enough to fix the 600 pixel netbook bug 1000781, but it is a start.

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks for taking the effort to extract it and put it into its own merge proposal!

+1 to go to trunk. Out of interest, if you've got a minute, could you elaborate in a comment what the issue actually was? That is, I understand that without the fix the window kept growing, but I'm not sure I can follow why.

review: Approve
Revision history for this message
Schwarzburg (stefan-schwarzburg) wrote :

I'm actually not really sure what is happening here. I was just observing that the window kept growing with each qrcode type. But I was sure that the qr_type.widget.grids were hidden.
The only explanation I could find was, that the window size was calculated at an earlier time. The first time to make sure that at max one qr_type is visible was this line in the code. So I did a test and it worked. (Thats a very typical way for an experimental physicist to handle bug searches :-)

However to fix the notebook size bug, we should think about moving the icons on the bottom to the side, where we have lots of space...

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: