Merge lp://staging/~stefan-schwarzburg/qreator/drag_n_drop_support into lp://staging/~dpm/qreator/trunk
Proposed by
Schwarzburg
| Status: | Merged |
|---|---|
| Merged at revision: | 88 |
| Proposed branch: | lp://staging/~stefan-schwarzburg/qreator/drag_n_drop_support |
| Merge into: | lp://staging/~dpm/qreator/trunk |
| Diff against target: |
49 lines (+32/-0) 1 file modified
qreator/QreatorWindow.py (+32/-0) |
| To merge this branch: | bzr merge lp://staging/~stefan-schwarzburg/qreator/drag_n_drop_support |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| David Planella | Approve | ||
|
Review via email:
|
|||
Description of the change
This adds basic drag support: the qrcode image can be draged into other applications. This behaves like the save feature: not the pixbuf is dragged, but the uri to a temporary file.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I like it, so merged it, thanks! :-)
A couple of things:
- I've changed the names of the callbacks to follow the same convention across the file (on_something instead of something_cb)
- Just an alternative, but instead of relying on a timeout to delete the temp file, you could have also used the atexit() function to delete it on exit
- I've tested the feature to work with Nautilus, but it does not work with Eye Of GNOME (on dragging and dropping the QR code, eog tells me it cannot find the file pointed by the UIR). Any ideas why not?