Merge lp://staging/~ssweeny/location-service/fix-lp1570878 into lp://staging/location-service/trunk
Proposed by
Scott Sweeny
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Thomas Voß | ||||
| Approved revision: | 252 | ||||
| Merged at revision: | 256 | ||||
| Proposed branch: | lp://staging/~ssweeny/location-service/fix-lp1570878 | ||||
| Merge into: | lp://staging/location-service/trunk | ||||
| Diff against target: |
162 lines (+55/-15) 6 files modified
include/location_service/com/ubuntu/location/fusion_provider.h (+1/-1) include/location_service/com/ubuntu/location/newer_or_more_accurate_update_selector.h (+11/-6) include/location_service/com/ubuntu/location/newer_update_selector.h (+2/-2) include/location_service/com/ubuntu/location/update_selector.h (+6/-2) src/location_service/com/ubuntu/location/fusion_provider.cpp (+5/-4) tests/provider_test.cpp (+30/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~ssweeny/location-service/fix-lp1570878 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomas Voß (community) | Approve | ||
| Jim Hodapp (community) | code | Approve | |
| PS Jenkins bot | continuous-integration | Pending | |
|
Review via email:
|
|||
Commit message
Fusion provider: Always use an update that came from the same source as the previous used update (fixes LP: #1570878)
Description of the change
Fix a bug in the fusion provider in which it is too strict about filtering updates which are slightly less accurate than previous updates. The new behavior is to automatically use an update which comes from the same source as the previous used update.
Tested by driving around on local highways and observing that I get position updates around once per second or better.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me after discussing a few questions that I had about the code with Scott. I would prefer to not have the value.value syntax but Scott told me it's not possible to avoid that without breaking the provider API.