location-service

Merge lp://staging/~ssweeny/location-service/espoo-delayed-provider.15.04 into lp://staging/location-service/15.04

  1. espoo-delayed-provider.15.04
  2. Merge into 15.04
Proposed by Scott Sweeny
Status: Needs review
Proposed branch: lp://staging/~ssweeny/location-service/espoo-delayed-provider.15.04
Merge into: lp://staging/location-service/15.04
Prerequisite: lp://staging/~ssweeny/location-service/delayed-providers.15.04
Diff against target: 220 lines (+141/-5)
5 files modified
include/location_service/com/ubuntu/location/provider.h (+1/-1)
src/location_service/com/ubuntu/location/provider.cpp (+1/-1)
src/location_service/com/ubuntu/location/providers/remote/provider.cpp (+136/-1)
src/location_service/com/ubuntu/location/providers/remote/provider.h (+2/-1)
tests/mock_delayed_provider.h (+1/-1)
To merge this branch: bzr merge lp://staging/~ssweeny/location-service/espoo-delayed-provider.15.04
Reviewer Review Type Date Requested Status
Thomas Voß (community) Needs Fixing
Review via email: mp+275424@code.staging.launchpad.net

Commit message

Ensure that we use a delayed provider when the espoo service is not running.

Description of the change

Ensure that the remote provider creates a delayed provider in the case in which the service is not ready. This allows the location service to be started without having the here blobs running.

To post a comment you must log in.
Revision history for this message
Thomas Voß (thomas-voss) wrote :

A remark inline about splitting changes between espoo-delayed.provider.15.04 and delayed-provider.15.04.

One other remark: I would prefer a set of more sophisticated test cases that exercise the timing logic. Otherwise, we would have to invest significant manual testing efforts for each landing to ensure correct behavior. Would you mind introducing such tests into this MP?

review: Needs Fixing
Reply
lp://staging/~ssweeny/location-service/espoo-delayed-provider.15.04 updated
200. By Scott Sweeny

Merge delayed-provider branch

Revision history for this message
Scott Sweeny (ssweeny) wrote :

I'm not clear on what tests you're looking for that aren't part of the other MP. Could you elaborate?

Reply
Revision history for this message
Thomas Voß (thomas-voss) wrote :

I was thinking about tests exercising the actual timing, something along the lines of a misbehaving provider that takes a configurable amount of time to come up. It might also be a good idea to test the overall location::Engine behavior with a couple of those providers registered. I hope that helps to clarify my line of thought.

Reply

Unmerged revisions

200. By Scott Sweeny

Merge delayed-provider branch

199. By Manuel de la Peña

Ensure that we use a delayed provider when the espoo service is not running.

198. By Manuel de la Peña

Added support for delayed providers.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches