Merge lp://staging/~ssweeny/location-service/async-providers.15.04 into lp://staging/location-service/15.04

Proposed by Scott Sweeny
Status: Merged
Approved by: Thomas Voß
Approved revision: 207
Merged at revision: 214
Proposed branch: lp://staging/~ssweeny/location-service/async-providers.15.04
Merge into: lp://staging/location-service/15.04
Diff against target: 622 lines (+412/-40)
13 files modified
examples/service/service.cpp (+14/-15)
include/location_service/com/ubuntu/location/provider_factory.h (+3/-0)
src/location_service/com/ubuntu/location/provider_factory.cpp (+14/-0)
src/location_service/com/ubuntu/location/providers/config.cpp (+7/-0)
src/location_service/com/ubuntu/location/providers/dummy/CMakeLists.txt (+3/-1)
src/location_service/com/ubuntu/location/providers/dummy/delayed_provider.cpp (+42/-0)
src/location_service/com/ubuntu/location/providers/dummy/delayed_provider.h (+62/-0)
src/location_service/com/ubuntu/location/providers/remote/provider.cpp (+23/-0)
src/location_service/com/ubuntu/location/service/daemon.cpp (+14/-17)
tests/CMakeLists.txt (+1/-0)
tests/delayed_service_test.cpp (+193/-0)
tests/mock_event_receiver.h (+35/-0)
tests/remote_providerd_test.cpp (+1/-7)
To merge this branch: bzr merge lp://staging/~ssweeny/location-service/async-providers.15.04
Reviewer Review Type Date Requested Status
Thomas Voß (community) code Approve
Review via email: mp+278092@code.staging.launchpad.net

Commit message

Allow providers to register themselves asynchronously

Description of the change

 * Allow providers to register themselves asynchronously.
 * Also, have the remote provider stub block until the actual remote provider has come up.
 * Add a dummy provider that takes a configurable amount of time to start up and a test to exercise provider/service behavior using it

To post a comment you must log in.
Revision history for this message
Thomas Voß (thomas-voss) wrote :

Yup, that matches perfectly what I had in mind. Go ahead please :)

Revision history for this message
Thomas Voß (thomas-voss) wrote :

Looking good thus far, a few niggles inline. Btw: indent with 4 spaces, please, indentation in namespaces is 0.

review: Needs Fixing
204. By Scott Sweeny

Factor MockEventReceiver into its own header

205. By Scott Sweeny

Use a DBus service watcher to detect when the remote service comes up instead of abusing exceptions

206. By Scott Sweeny

Merge from 15.04 branch

207. By Scott Sweeny

Add myself as an author of the test that I stole/wrote

Revision history for this message
Thomas Voß (thomas-voss) wrote :

Thanks for the changes, a remark inline.

review: Needs Fixing
208. By Scott Sweeny

Use a condition variable to wait for the remote service instead of a busy loop

Revision history for this message
Scott Sweeny (ssweeny) wrote :

Good suggestion :)

Revision history for this message
Thomas Voß (thomas-voss) wrote :

LGTM, time to get a silo.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches