Merge lp://staging/~sseman/juju-ci-tools/model-change-watcher-py3-2 into lp://staging/juju-ci-tools
Proposed by
Seman
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~sseman/juju-ci-tools/model-change-watcher-py3-2 |
Merge into: | lp://staging/juju-ci-tools |
Prerequisite: | lp://staging/~sseman/juju-ci-tools/model-change-watcher-py3 |
Diff against target: |
288 lines (+244/-11) 3 files modified
Makefile (+6/-3) jujupy.py (+0/-8) tests_py3/test_assess_model_change_watcher.py (+238/-0) |
To merge this branch: | bzr merge lp://staging/~sseman/juju-ci-tools/model-change-watcher-py3-2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nicholas Skaggs (community) | Approve | ||
Curtis Hovey (community) | code | Needs Information | |
Review via email: mp+312755@code.staging.launchpad.net |
Description of the change
This is the second branch that adds unit tests for the assess_
It also updates the Makefile so that the right version of Python is used to run unittest and flake8. "unittest" doesn't make it simple to exclude some files, example excluding Python 3 files when running Python 2 tests, therefore I created a different directory for Python 3 test scripts.
First branch:
https:/
To post a comment you must log in.
I'll wait until the pre-req is landed. However, 1 comment below.