Maya

Merge lp://staging/~sschuhmann/maya/guestview into lp://staging/~elementary-apps/maya/trunk

  1. guestview
  2. Merge into trunk
Proposed by Steffen Schuhmann
Status: Merged
Approved by: Corentin Noël
Approved revision: 617
Merged at revision: 609
Proposed branch: lp://staging/~sschuhmann/maya/guestview
Merge into: lp://staging/~elementary-apps/maya/trunk
Diff against target: 471 lines (+282/-42)
4 files modified
CMakeLists.txt (+3/-1)
src/CMakeLists.txt (+2/-1)
src/EventEdition/ContactImage.vala (+125/-0)
src/EventEdition/GuestsPanel.vala (+152/-40)
To merge this branch: bzr merge lp://staging/~sschuhmann/maya/guestview
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Danielle Foré Needs Fixing
Review via email: mp+228572@code.staging.launchpad.net

Commit message

Guest View:
 * Added libfolks support.
 * Ported to ListBox.
 * Changed entry string.
 * Invitation status now shows the real status.

Description of the change

Contact lookup added.
ListBox added.

ListBox seems not to themed in egtk, should this be done in maya itself?

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

The code is great, adding the design team to review the problem with the listbox (if it's not themeable, a Frame can be added)

review: Approve
Revision history for this message
Steffen Schuhmann (sschuhmann) wrote :

Needs fixing.

This may cause bug 1349853, which i thought is also in the upstream version.

Revision history for this message
Steffen Schuhmann (sschuhmann) wrote :

> Needs fixing.
>
> This may cause bug 1349853, which i thought is also in the upstream version.

Tested the development branch contains this bug also.

lp://staging/~sschuhmann/maya/guestview updated
614. By Steffen Schuhmann

Fixes

615. By Steffen Schuhmann

fixes

Revision history for this message
Danielle Foré (danrabbit) wrote :

I've added theming for gtk 3.14. I'll have to add it for 3.12 later :p

Can we remove the ellipsis from the placeholder text in the search entry?

Also, adding a contact should probably clear the entry.

How does the "pending" functionality work? If you add someone that isn't tied to a contact (just some random name) we probably shouldn't show the status since they won't be able to confirm.

also, if these are bugs that are present in trunk and don't have anything to do with your branch feel free to ignore them :)

review: Needs Fixing
Revision history for this message
Steffen Schuhmann (sschuhmann) wrote :

> Also, adding a contact should probably clear the entry.

I'll add that

> How does the "pending" functionality work? If you add someone that isn't tied to a contact (just some random name) we probably shouldn't show the status since they won't be able to confirm.

The user should enter an mail address than just a random name, or is that something, that is uncertain?

lp://staging/~sschuhmann/maya/guestview updated
616. By Steffen Schuhmann

Deleting content of Gtk.Entry when choosing a suggestion.
Removed ellipsis in the "Invite" string.

617. By Steffen Schuhmann

Invitation status now only displays approved and declined invitation status. If there isn't a invitation send or it's pendig it doesn't display anything.

Revision history for this message
Corentin Noël (tintou) wrote :

With your latest changes it's better than ever, ready to merge.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches