Merge lp://staging/~sschuhmann/maya/fix-1347727 into lp://staging/~elementary-apps/maya/trunk
Proposed by
Steffen Schuhmann
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Corentin Noël | ||||
| Approved revision: | 608 | ||||
| Merged at revision: | 613 | ||||
| Proposed branch: | lp://staging/~sschuhmann/maya/fix-1347727 | ||||
| Merge into: | lp://staging/~elementary-apps/maya/trunk | ||||
| Diff against target: |
152 lines (+29/-35) 1 file modified
src/EventEdition/ReminderPanel.vala (+29/-35) |
||||
| To merge this branch: | bzr merge lp://staging/~sschuhmann/maya/fix-1347727 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Corentin Noël | Approve | ||
|
Review via email:
|
|||
Commit message
Ported the reminder pane to Gtk.ListBox
Description of the change
Gtk.ListBox added to hold the items.
Gtk.Listbox seems not to be themed in egtk, should this be done in maya itself?
To post a comment you must log in.
Revision history for this message
| Corentin Noël (tintou) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I think that ReminderGrid could be a subclass of Gtk.ListBoxRow.
So the reminders property could being removed.
about set_margin_* (7);
We typically use 6px or 12px for margin.