Maya

Merge lp://staging/~sschuhmann/maya/fix-1338055 into lp://staging/~elementary-apps/maya/trunk

  1. fix-1338055
  2. Merge into trunk
Proposed by Steffen Schuhmann
Status: Merged
Approved by: Corentin Noël
Approved revision: 600
Merged at revision: 599
Proposed branch: lp://staging/~sschuhmann/maya/fix-1338055
Merge into: lp://staging/~elementary-apps/maya/trunk
Diff against target: 21 lines (+4/-1)
1 file modified
src/EventEdition/InfoPanel.vala (+4/-1)
To merge this branch: bzr merge lp://staging/~sschuhmann/maya/fix-1338055
Reviewer Review Type Date Requested Status
Corentin Noël Approve
Review via email: mp+225750@code.staging.launchpad.net

Commit message

Check end date of event.

Description of the change

Check the end date of an event, if it's smaller than the from date set the from date to the same.

To post a comment you must log in.
Revision history for this message
Corentin Noël (tintou) wrote :

I would rather use DateTime.compare () instead so It would check the year too.
Please remove the empty line after bracket opening.

review: Needs Fixing
lp://staging/~sschuhmann/maya/fix-1338055 updated
600. By Schuhmann Steffen <email address hidden>

empty lines removed

Revision history for this message
Steffen Schuhmann (sschuhmann) wrote :

I have removed the empty lines after the bracket opening.
Check for same year is in the first if-statement.

Revision history for this message
Corentin Noël (tintou) wrote :

Okay, so the save-button sensitivity should be fixed in another commit.

review: Approve
Revision history for this message
Steffen Schuhmann (sschuhmann) wrote :

save-button sensivity? did i miss something?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches