Ubuntu
likewise-open package

Merge lp://staging/~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-751807 into lp://staging/ubuntu/natty/likewise-open

  1. Natty (11.04)
  2. likewise-open-fix-751807
  3. Merge into natty
Proposed by Scott Salley
Status: Merged
Merged at revision: 26
Proposed branch: lp://staging/~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-751807
Merge into: lp://staging/ubuntu/natty/likewise-open
Diff against target: 45 lines (+28/-0)
2 files modified
debian/changelog (+6/-0)
debian/likewise-open.preinst (+22/-0)
To merge this branch: bzr merge lp://staging/~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-751807
Reviewer Review Type Date Requested Status
Dustin Kirkland  Approve
Ubuntu branches Pending
Review via email: mp+56620@code.staging.launchpad.net

Description of the change

No code was changed, just the preinst script.

This change corrects the likewise-open.preinst script to shutdown the daemons in Likewise Open 5.4 on upgrade. Somehow I missed the fact that much of the upgrade related code was not being called for upgrades from Likweise Open 5.4 -- probably because the only real task from upgrading from 5.4 is to make sure 5.4 is shutdown cleanly.

Test by installing likewise-open in Ubuntu 10.10 and upgrading to Natty.

For expediency in testing, I put a 'hold' on likewise-open in Ubuntu 10.10, did a Natty upgrade, and then took a snapshot of my VM. I then tested the likewise-open package I built by starting the snapshot and installing with dpkg. Anyone see a problem with doing an upgrade test like this?

To post a comment you must log in.
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hi Scott,

I'm going to approve/merge this for Natty.

However, calling /etc/init.d/* directly from preinst/postinst scripts is not recommended.

Instead, you're supposed to use update-rc.d. See the Debian Policy Manual, section 9.3.3:
 * http://www.debian.org/doc/debian-policy/ch-opersys.html

Grepping through your debian directory, I see ~30 or so "violations", so I accepted your merge proposal as-is, in the interest of consistency.

I would recommend taking a look at this in depth for a future release (after Natty). Ping me in IRC if you have more questions!

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: