Merge lp://staging/~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-737362 into lp://staging/ubuntu/natty/likewise-open
| Status: | Merged |
|---|---|
| Merged at revision: | 25 |
| Proposed branch: | lp://staging/~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-737362 |
| Merge into: | lp://staging/ubuntu/natty/likewise-open |
| Diff against target: |
127 lines (+78/-0) 5 files modified
debian/changelog (+10/-0) debian/likewise-open.preinst (+1/-0) debian/likewise-open.prerm (+2/-0) debian/patches/remove-pid.diff (+64/-0) debian/patches/series (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~ssalley/ubuntu/natty/likewise-open/likewise-open-fix-737362 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Marc Deslauriers | Approve | ||
| Ubuntu branches | Pending | ||
|
Review via email:
|
|||
Description of the change
PID file mis-management appears to be the root cause of bug 737362 (and many other bugs from previous releases).
This change patches the daemons to remove their PID file on a clean exit and modifies the post-/pre-install scripts to handle pid files left by older versions or by daemons that were not stopped cleanly.
The patch for the daemons is being pushed upstream.
Possible tests:
Test 1: Install Ubuntu 10.10 with likewise-open. Do an upgrade to 11.04. See if likewise-open upgraded cleanly. [You should repeat this test a 1000 times because of non-deterministic behavior :-) ]
Test 2: Install Ubuntu 11.04. Install likewise-open. Remove likewise-open. No likewise-open pid files should remain in /var/run.
Test 3: Install Ubuntu 11.04. Install likewise-open. Stop a daemon: /opt/likewise/
Changes look good. ACK.
Though, next time, could you please tag the patches in debian/patches as per DEP3?:
http://
We are currently in beta freeze, once freeze is over this package should get uploaded.
Thanks!