Plank

Merge lp://staging/~spinatelli/plank/improve-launcher-managing into lp://staging/~docky-core/plank/plank-dnd

improve-launcher-managing
Merge into plank-dnd

Proposed by Sergio Spinatelli on 2011-03-19

Status:	Rejected
Rejected by:	Robert Dyer on 2011-03-21
Proposed branch:	lp://staging/~spinatelli/plank/improve-launcher-managing
Merge into:	lp://staging/~docky-core/plank/plank-dnd
Diff against target:	66 lines (+23/-6) 1 file modified Plank/DragManager.vala (+23/-6)
To merge this branch:	bzr merge lp://staging/~spinatelli/plank/improve-launcher-managing
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Robert Dyer (community)		2011-03-19	Disapprove on 2011-03-21
Review via email: mp+54109@code.staging.launchpad.net

Description of the change

The branch improves launcher management (placing launchers on the dock,moving them within the dock and removing them).

lp://staging/~spinatelli/plank/improve-launcher-managing updated on 2011-03-19

259. By Sergio Spinatelli on 2011-03-19: Fix coding style and comment file deletion out

Revision history for this message

Robert Dyer (psybers) wrote on 2011-03-21:

Style issues:

- Ln 23 - remove blank line
- Lns 35, 54, 62 - make sure space before '+1' or '-1' -> ' + 1' and ' - 1'
- Lns 34/36 - dont need brackets

review: Needs Fixing

Revision history for this message

Robert Dyer (psybers) wrote on 2011-03-21:

Regarding setting the sort values, instead of doing the other item +1 or -1, I think it might make sense to just swap the sort values of the two items. Only IF adding a new one, do a +-1.

Also this needs a LOT of rethinking in general. You see, if you set the Sort on an item that will immediately serialize that value to the .dockitem backing it. Then the file monitors will see a change and trigger a reload of dock items. So you probably are getting some nasty behavior here.

It might make sense to just play with the Position (which isnt serialized) and then when a drag finishes, go through and update any Sorts.

review: Needs Fixing

Revision history for this message

Robert Dyer (psybers) wrote on 2011-03-21:

As such I reject this.

review: Disapprove

Revision history for this message

Robert Dyer (psybers) on 2011-03-21:

review: Disapprove

Unmerged revisions

261. By Sergio Spinatelli on 2011-03-29: Change managing:update sorting value in the dockitem only when the drag actually ends
260. By Sergio Spinatelli on 2011-03-21: Fix coding style
259. By Sergio Spinatelli on 2011-03-19: Fix coding style and comment file deletion out
258. By Sergio Spinatelli on 2011-03-18: Merge trunk
257. By Sergio Spinatelli on 2011-03-17: Merge trunk
256. By Sergio Spinatelli on 2011-03-16: Improve launcher managing (moving,adding,removing)