Merge lp://staging/~speijnik/gnome-control-center/bug-559106 into lp://staging/~ubuntu-desktop/gnome-control-center/ubuntu

Proposed by Stephan Peijnik
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~speijnik/gnome-control-center/bug-559106
Merge into: lp://staging/~ubuntu-desktop/gnome-control-center/ubuntu
Diff against target: 139 lines (+28/-26)
1 file modified
debian/patches/95_desktop-effects-integration.patch (+28/-26)
To merge this branch: bzr merge lp://staging/~speijnik/gnome-control-center/bug-559106
Reviewer Review Type Date Requested Status
Sebastien Bacher Disapprove
Review via email: mp+23086@code.staging.launchpad.net

Description of the change

Fix for LP:559106. Now checking for existence of /usr/share/doc/compiz and /usr/share/doc/compiz-gnome before enabling visual effects tab.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

The fix is wrong as explained in the bug report, if compiz is installed in the path it should be able to run otherwise the compiz packaging is buggy

review: Disapprove

Unmerged revisions

169. By Stephan Peijnik

Added additional checks for disabling visual effects tab in Appearance Properties (checking for existence of /usr/share/doc/compiz and /usr/share/doc/compiz-gnome now, which will exist if both compiz and compiz-gnome are installed).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches