OpenStack Compute (nova)

Merge lp://staging/~soren/nova/lp733609 into lp://staging/~hudson-openstack/nova/trunk

lp733609
Merge into trunk

Proposed by Soren Hansen on 2011-03-14

Status:

Merged

Approved by:

Rick Harris on 2011-03-17

Approved revision:

797

Merged at revision:

822

Proposed branch:

lp://staging/~soren/nova/lp733609

Merge into:

lp://staging/~hudson-openstack/nova/trunk

Diff against target:

143 lines (+93/-10)

2 files modified

nova/tests/test_utils.py (+78/-0)
nova/utils.py (+15/-10)

To merge this branch:

bzr merge lp://staging/~soren/nova/lp733609

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Rick Harris (community)		Approve on 2011-03-17
Paul Voccio (community)	2011-03-14	Approve on 2011-03-17
Review via email: mp+53321@code.staging.launchpad.net

Commit message

Make utils.execute not overwrite std{in,out,err} args to Popen on retries.
Make utils.execute reject unknown kwargs.

Add a couple of unit tests for utils.execute.

Revision history for this message

Paul Voccio (pvo) wrote on 2011-03-17:

lgtm

review: Approve

Revision history for this message

Rick Harris (rconradharris) wrote on 2011-03-17:

Patch looks really good.

Received a few pep8 nits from the test-suite: http://paste.openstack.org/show/921/

review: Needs Fixing

Revision history for this message

Soren Hansen (soren) wrote on 2011-03-17:

> Patch looks really good.
>
> Received a few pep8 nits from the test-suite:
> http://paste.openstack.org/show/921/

*sigh* Fixed. I keep forgetting to run pep8 manually (because I have that test case that fails due to non-ascii stuff in the help text, so run_tests.sh skips pep8). I've given myself a good shouting at. Apologies. :(

lp://staging/~soren/nova/lp733609 updated on 2011-03-17