Merge lp://staging/~songofacandy/bzr/user_encoding_utf8 into lp://staging/bzr/2.5
Proposed by
methane
Status: | Rejected |
---|---|
Rejected by: | Martin Packman |
Proposed branch: | lp://staging/~songofacandy/bzr/user_encoding_utf8 |
Merge into: | lp://staging/bzr/2.5 |
Diff against target: |
136 lines (+39/-9) 3 files modified
bzrlib/builtins.py (+3/-3) bzrlib/msgeditor.py (+18/-6) bzrlib/tests/test_msgeditor.py (+18/-0) |
To merge this branch: | bzr merge lp://staging/~songofacandy/bzr/user_encoding_utf8 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Packman (community) | Disapprove | ||
Vincent Ladeuil | Needs Fixing | ||
Review via email:
|
Description of the change
Add ``editor_encoding`` configuration to allow writing non-ascii commit message without locale setting.
To post a comment you must log in.
INADA Naoki пишет: /code.launchpad .net/~songofaca ndy/bzr/ user_encoding_ utf8/+merge/ 90039 get_user_ encoding( ) fallbacks to utf8 instead of ascii.
> INADA Naoki has proposed merging lp:~songofacandy/bzr/user_encoding_utf8 into lp:bzr/2.5.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> For more details, see:
> https:/
>
> * osutils.
> * Add BZR_USER_ENCODING envvar to override user encoding.
The latter sounds great!
I've spotted small typo in your patch though:
+ if old_env is not None: 'BZR_USER_ ENCODING' ] = old_env
+ os.envirion[
should be os.environ.
But I think bzrlib.osutils already has special method to set/unset
environment variables, and in the tests you should use it instead of
manual manipulations.
--
All the dude wanted was his rug back