Merge lp://staging/~smspillaz/compiz-core/oneiric.fix_918762 into lp://staging/compiz-core/oneiric

Proposed by Sam Spilsbury
Status: Merged
Approved by: Sam Spilsbury
Approved revision: 2830
Merged at revision: 2830
Proposed branch: lp://staging/~smspillaz/compiz-core/oneiric.fix_918762
Merge into: lp://staging/compiz-core/oneiric
Diff against target: 21 lines (+10/-2)
1 file modified
src/window.cpp (+10/-2)
To merge this branch: bzr merge lp://staging/~smspillaz/compiz-core/oneiric.fix_918762
Reviewer Review Type Date Requested Status
Daniel van Vugt Approve
Michal Hruby (community) Approve
Review via email: mp+89279@code.staging.launchpad.net

Description of the change

Fixes lp #918762

  Fix potential crash in PrivateWindow::configure LP #918762

  If a window was at the bottom of the stack and then received a ConfigureNotify event to go higher,
  we would check its previous window if it was the requested sibling and ignore the request, which
  is an error when the window is at the bottom

To post a comment you must log in.
Revision history for this message
Michal Hruby (mhr3) wrote :

I've hit this issue, and the fix looks good, approving.

review: Approve
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Looks good. Identical to the fix upstream and merges builds perfectly.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches