Compiz Core

Merge lp://staging/~smspillaz/compiz-core/decor.input_extents_update into lp://staging/compiz-core

  1. decor.input_extents_update
  2. Merge into 0.9.7
Proposed by Sam Spilsbury
Status: Rejected
Rejected by: Sam Spilsbury
Proposed branch: lp://staging/~smspillaz/compiz-core/decor.input_extents_update
Merge into: lp://staging/compiz-core
Diff against target: 69 lines (+14/-10)
1 file modified
plugins/decor/src/decor.cpp (+14/-10)
To merge this branch: bzr merge lp://staging/~smspillaz/compiz-core/decor.input_extents_update
Reviewer Review Type Date Requested Status
Sam Spilsbury Disapprove
Daniel van Vugt Needs Fixing
Alan Griffiths Needs Fixing
Review via email: mp+102062@code.staging.launchpad.net

Description of the change

Don't update the frame window until input extents are updated

To post a comment you must log in.
Revision history for this message
Alan Griffiths (alan-griffiths) wrote :

CompWindowExtents (a.k.a. compiz::window::extents::Extents) has a default constructor, if that works, then "memset (&emptyExtents, 0, sizeof (CompWindowExtents));" shouldn't be necessary, if it doesn't then the ctor should be fixed.

review: Needs Fixing
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Also, bug 981703 is still present. Not fixed.

review: Needs Fixing
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Doesn't work, rejecting

review: Disapprove

Unmerged revisions

3093. By Sam Spilsbury

Check against input extents and don't update the frame window until all
input extents are updated

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches